From patchwork Wed Sep  1 09:38:26 2010
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-Patchwork-Submitter: Li Zefan <lizf@cn.fujitsu.com>
X-Patchwork-Id: 146561
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o819Y0kr004911
	for <patchwork-kvm@patchwork.kernel.org>; Wed, 1 Sep 2010 09:34:22 GMT
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753835Ab0IAJdc (ORCPT
	<rfc822;patchwork-kvm@patchwork.kernel.org>);
	Wed, 1 Sep 2010 05:33:32 -0400
Received: from cn.fujitsu.com ([222.73.24.84]:64662 "EHLO
	song.cn.fujitsu.com"
	rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP
	id S1752767Ab0IAJdb (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 1 Sep 2010 05:33:31 -0400
Received: from tang.cn.fujitsu.com (tang.cn.fujitsu.com [10.167.250.3])
	by song.cn.fujitsu.com (Postfix) with ESMTP id E2C38170135;
	Wed,  1 Sep 2010 17:33:29 +0800 (CST)
Received: from fnst.cn.fujitsu.com (tang.cn.fujitsu.com [127.0.0.1])
	by tang.cn.fujitsu.com (8.14.3/8.13.1) with ESMTP id o819U5te032274;
	Wed, 1 Sep 2010 17:30:05 +0800
Received: from lizf.localdomain (unknown [10.167.141.140])
	by fnst.cn.fujitsu.com (Postfix) with ESMTPA id CBA7A14C031;
	Wed,  1 Sep 2010 17:34:48 +0800 (CST)
Message-ID: <4C7E1F12.8030304@cn.fujitsu.com>
Date: Wed, 01 Sep 2010 17:38:26 +0800
From: Li Zefan <lizf@cn.fujitsu.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11
	Thunderbird/3.0b2
MIME-Version: 1.0
To: Avi Kivity <avi@redhat.com>
CC: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@elte.hu>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>, kvm-devel <kvm@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: ftrace/perf_event leak
References: <4C7E11E5.1040402@redhat.com> <1283331868.2059.808.camel@laptop>
	<4C7E1C36.6070400@redhat.com>
In-Reply-To: <4C7E1C36.6070400@redhat.com>
Sender: kvm-owner@vger.kernel.org
Precedence: bulk
List-ID: <kvm.vger.kernel.org>
X-Mailing-List: kvm@vger.kernel.org
X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by
	milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]);
	Wed, 01 Sep 2010 09:34:22 +0000 (UTC)


diff --git a/kernel/trace/trace_event_perf.c b/kernel/trace/trace_event_perf.c
index 8a2b73f..9d1d1f2 100644
--- a/kernel/trace/trace_event_perf.c
+++ b/kernel/trace/trace_event_perf.c
@@ -161,6 +161,7 @@ void perf_trace_destroy(struct perf_event *p_event)
 		}
 	}
 out:
+	module_put(tp_event->mod);
 	mutex_unlock(&event_mutex);
 }