diff mbox

KVM: Clarify KVM_ASSIGN_PCI_DEVICE documentation

Message ID 4DE79B29.6030609@web.de (mailing list archive)
State New, archived
Headers show

Commit Message

Jan Kiszka June 2, 2011, 2:16 p.m. UTC 
From: Jan Kiszka <jan.kiszka@siemens.com>

Neither host_irq nor the guest_msi struct are used anymore today.
Tag the former, drop the latter to avoid confusion.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
 Documentation/virtual/kvm/api.txt |    7 +------
 1 files changed, 1 insertions(+), 6 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Marcelo Tosatti June 3, 2011, 2:04 a.m. UTC | #1 
On Thu, Jun 02, 2011 at 04:16:09PM +0200, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Neither host_irq nor the guest_msi struct are used anymore today.
> Tag the former, drop the latter to avoid confusion.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  Documentation/virtual/kvm/api.txt |    7 +------
>  1 files changed, 1 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
> index 2bd06b0..7adc1ac 100644
> --- a/Documentation/virtual/kvm/api.txt
> +++ b/Documentation/virtual/kvm/api.txt
> @@ -1143,15 +1143,10 @@ Assigns an IRQ to a passed-through device.
>  
>  struct kvm_assigned_irq {
>  	__u32 assigned_dev_id;
> -	__u32 host_irq;
> +	__u32 host_irq;		/* ignored (legacy field) */
>  	__u32 guest_irq;
>  	__u32 flags;
>  	union {
> -		struct {
> -			__u32 addr_lo;
> -			__u32 addr_hi;
> -			__u32 data;
> -		} guest_msi;
>  		__u32 reserved[12];
>  	};
>  };

Please update the kernel headers accordingly.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt
index 2bd06b0..7adc1ac 100644
--- a/Documentation/virtual/kvm/api.txt
+++ b/Documentation/virtual/kvm/api.txt
@@ -1143,15 +1143,10 @@  Assigns an IRQ to a passed-through device.
 
 struct kvm_assigned_irq {
 	__u32 assigned_dev_id;
-	__u32 host_irq;
+	__u32 host_irq;		/* ignored (legacy field) */
 	__u32 guest_irq;
 	__u32 flags;
 	union {
-		struct {
-			__u32 addr_lo;
-			__u32 addr_hi;
-			__u32 data;
-		} guest_msi;
 		__u32 reserved[12];
 	};
 };