From patchwork Tue Jul 12 20:00:22 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 969182 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p6CK0kQH011924 for ; Tue, 12 Jul 2011 20:00:47 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755176Ab1GLUA1 (ORCPT ); Tue, 12 Jul 2011 16:00:27 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:49172 "EHLO fmmailgate03.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755153Ab1GLUAY (ORCPT ); Tue, 12 Jul 2011 16:00:24 -0400 Received: from smtp04.web.de ( [172.20.0.225]) by fmmailgate03.web.de (Postfix) with ESMTP id 95DB819546FAC; Tue, 12 Jul 2011 22:00:22 +0200 (CEST) Received: from [88.64.3.93] (helo=mchn199C.mchp.siemens.de) by smtp04.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.110 #2) id 1Qgj82-0000od-00; Tue, 12 Jul 2011 22:00:22 +0200 Message-ID: <4E1CA7D6.4090203@web.de> Date: Tue, 12 Jul 2011 22:00:22 +0200 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Avi Kivity , Marcelo Tosatti CC: Xiao Guangrong , LKML , KVM Subject: [PATCH] KVM: x86: Apply required parentheses in __check_direct_spte_mmio_pf References: <4E1B4CF8.605@cn.fujitsu.com> <4E1B5018.7070008@cn.fujitsu.com> In-Reply-To: <4E1B5018.7070008@cn.fujitsu.com> X-Enigmail-Version: 1.2 X-Sender: jan.kiszka@web.de X-Provags-ID: V01U2FsdGVkX1+yPl2321ftemIvhSIuCxryc5Vr901BVbbNWCvf XIpMWuto3SlKURXfs7Zjld23TQFg8FFSpld9rJ/Frt5+VCtpBn QjbTPAYRg= Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Tue, 12 Jul 2011 20:00:47 +0000 (UTC) From: Jan Kiszka Comparison takes precedence over bitwise &, but the latter needs to be evaluated first here. Signed-off-by: Jan Kiszka --- Avi, how's your 32-bit buildbot? arch/x86/kvm/mmu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index d3d188e..9335e1b 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -448,7 +448,7 @@ static bool __check_direct_spte_mmio_pf(u64 spte) /* It is valid if the spte is being zapped. */ if (sspte.spte_low == 0ull && - sspte.spte_high & high_mmio_mask == high_mmio_mask) + (sspte.spte_high & high_mmio_mask) == high_mmio_mask) return true; return false;