From patchwork Wed Aug 31 00:03:47 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Friesen X-Patchwork-Id: 1114662 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p7V03w3x013562 for ; Wed, 31 Aug 2011 00:03:58 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754033Ab1HaADx (ORCPT ); Tue, 30 Aug 2011 20:03:53 -0400 Received: from exprod7og108.obsmtp.com ([64.18.2.169]:51039 "EHLO exprod7og108.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754000Ab1HaADw (ORCPT ); Tue, 30 Aug 2011 20:03:52 -0400 Received: from mail.genband.com ([63.149.188.88]) (using TLSv1) by exprod7ob108.postini.com ([64.18.6.12]) with SMTP ID DSNKTl16Ztq35ul0ejsSj+LZgs4suKdQ1lqy@postini.com; Tue, 30 Aug 2011 17:03:52 PDT Received: from gbausmail.genband.com ([172.16.21.62]) by mail.genband.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 30 Aug 2011 19:03:48 -0500 Received: from [1.220.30.139] ([1.220.30.139]) by gbausmail.genband.com with Microsoft SMTPSVC(6.0.3790.4675); Tue, 30 Aug 2011 19:03:48 -0500 Message-ID: <4E5D7A63.5080706@genband.com> Date: Tue, 30 Aug 2011 18:03:47 -0600 From: Chris Friesen User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.20) Gecko/20110817 Fedora/3.1.12-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.12 MIME-Version: 1.0 To: Jan Kiszka CC: Avi Kivity , mtosatti@redhat.com, kvm@vger.kernel.org Subject: [BUG] error compiling qemu-kvm-0.15.0 without vnc References: <4E5D0FF3.6030705@genband.com> <4E5D23F5.3070905@gmail.com> <4E5D27B5.8090004@genband.com> <4E5D2C68.2050801@gmail.com> <4E5D3C67.1020908@genband.com> <4E5D413D.1070700@web.de> In-Reply-To: <4E5D413D.1070700@web.de> X-OriginalArrivalTime: 31 Aug 2011 00:03:48.0645 (UTC) FILETIME=[7574B550:01CC6771] X-TM-AS-Product-Ver: SMEX-8.0.0.4160-6.500.1024-18356.003 X-TM-AS-Result: No--15.613300-5.000000-31 X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Wed, 31 Aug 2011 00:03:58 +0000 (UTC) Hi, I've run into another problem. I configured qemu-kvm-0.15.0 as: ./configure --target-list="i386-softmmu,x86_64-softmmu" --disable-sdl --disable-vnc --disable-curses Building it, I get: CC i386-softmmu/pcspk.o CC i386-softmmu/i8254.o CC i386-softmmu/i8254-kvm.o CC i386-softmmu/device-assignment.o LINK i386-softmmu/qemu monitor.o: In function `add_graphics_client': /home/cfriesen/Download/qemu-kvm-0.15.0/monitor.c:1226: undefined reference to `vnc_display_add_client' collect2: ld returned 1 exit status make[1]: *** [qemu] Error 1 make: *** [subdir-i386-softmmu] Error 2 The following patch allowed it to compile, but I don't know enough about kvm to know if this is the proper thing to do. Chris Index: cfriesen/Download/qemu-kvm-0.15.0/console.h =================================================================== --- cfriesen.orig/Download/qemu-kvm-0.15.0/console.h +++ cfriesen/Download/qemu-kvm-0.15.0/console.h @@ -372,15 +372,18 @@ void cocoa_display_init(DisplayState *ds void vnc_display_init(DisplayState *ds); void vnc_display_close(DisplayState *ds); int vnc_display_open(DisplayState *ds, const char *display); -void vnc_display_add_client(DisplayState *ds, int csock, int skipauth); int vnc_display_disable_login(DisplayState *ds); char *vnc_display_local_addr(DisplayState *ds); #ifdef CONFIG_VNC +void vnc_display_add_client(DisplayState *ds, int csock, int skipauth); int vnc_display_password(DisplayState *ds, const char *password); int vnc_display_pw_expire(DisplayState *ds, time_t expires); void do_info_vnc_print(Monitor *mon, const QObject *data); void do_info_vnc(Monitor *mon, QObject **ret_data); #else +static inline void vnc_display_add_client(DisplayState *ds, int csock, int skipauth) +{ +} static inline int vnc_display_password(DisplayState *ds, const char *password) { qerror_report(QERR_FEATURE_DISABLED, "vnc");