From patchwork Sun Dec 2 10:04:14 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 1830211 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 601D43FCA5 for ; Sun, 2 Dec 2012 10:05:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752487Ab2LBKFv (ORCPT ); Sun, 2 Dec 2012 05:05:51 -0500 Received: from mout.web.de ([212.227.17.11]:63794 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751647Ab2LBKFv (ORCPT ); Sun, 2 Dec 2012 05:05:51 -0500 Received: from mchn199C.mchp.siemens.de ([95.157.56.37]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0MfHfy-1Tpe0D1ADK-00OzAQ; Sun, 02 Dec 2012 11:04:15 +0100 Message-ID: <50BB279E.1090105@web.de> Date: Sun, 02 Dec 2012 11:04:14 +0100 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Marcelo Tosatti , Gleb Natapov CC: kvm , Guo Chao Subject: [PATCH v2] KVM: x86: Fix uninitialized return code References: <50BB2657.9010104@web.de> In-Reply-To: <50BB2657.9010104@web.de> X-Enigmail-Version: 1.4.6 X-Provags-ID: V02:K0:g0rUmgVFdfiU1t7NSgI0Vp15vKKZ2UNm9Iejx43jjzv vf+Alt4Y+YPJWaUuWRHSELN+ORjR9jsK+p9+Wncdw3xR7X6Whe egkVyLpT7pTQ6pxoWaNuctbr1StFnKl/+c3+RuJDN5tm9jYq8K qz0/zKHFEyLCUeN+XUbGJ8njZ66a0KYn8fEuDC/hGpkd8NZyZK L8W2JS7yJ1SlE2HPcec5A== Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Jan Kiszka This is a regression caused by 18595411a7. Signed-off-by: Jan Kiszka --- Sorry, copy&pasted wrong error code. arch/x86/kvm/x86.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index b0b8abe..3bdaf29 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -3006,6 +3006,7 @@ long kvm_arch_vcpu_ioctl(struct file *filp, break; } case KVM_SET_LAPIC: { + r = -EINVAL; if (!vcpu->arch.apic) goto out; u.lapic = memdup_user(argp, sizeof(*u.lapic));