From patchwork Sat Feb 23 21:35:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 2178781 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id ACD9F3FCF6 for ; Sat, 23 Feb 2013 21:35:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759406Ab3BWVfa (ORCPT ); Sat, 23 Feb 2013 16:35:30 -0500 Received: from mout.web.de ([212.227.15.3]:57847 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759381Ab3BWVf1 (ORCPT ); Sat, 23 Feb 2013 16:35:27 -0500 Received: from mchn199C.mchp.siemens.de ([95.157.56.37]) by smtp.web.de (mrweb102) with ESMTPSA (Nemesis) id 0MMmx9-1UCvW00FOJ-008Tem; Sat, 23 Feb 2013 22:35:23 +0100 Message-ID: <5129361A.7090608@web.de> Date: Sat, 23 Feb 2013 22:35:22 +0100 From: Jan Kiszka User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 To: Marcelo Tosatti , Gleb Natapov CC: kvm , Nadav Har'El , "Nakajima, Jun" Subject: [PATCH] KVM: nVMX: Replace kvm_set_cr0 with vmx_set_cr0 in load_vmcs12_host_state X-Enigmail-Version: 1.5 X-Provags-ID: V02:K0:BqpF/w+PwnSz4QVrbgJA8MF8yYwjLDqY+EywzosDQne uuuhOIon6T2JKjTPMybgBVrNy4nTiLI6eLuEGCELpPzI2DQJjL XR2pxOn4QP7nr0JJVTKxI5Qb2zv1gnrRyh9d8Af8XAj/GmmTS0 /RDzDgMGMFFtwDGifYZ+KCbOBNoYG4bUnAEPg4h9vdgFml/ZN4 e7i6KG3hfyQ/CKVqaLS4A== Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Jan Kiszka Likely a typo, but a fatal one as kvm_set_cr0 performs checks on the state transition that may prevent loading L1's cr0. Signed-off-by: Jan Kiszka --- arch/x86/kvm/vmx.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 26d47e9..94f3b66 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -7429,7 +7429,7 @@ static void load_vmcs12_host_state(struct kvm_vcpu *vcpu, * fpu_active (which may have changed). * Note that vmx_set_cr0 refers to efer set above. */ - kvm_set_cr0(vcpu, vmcs12->host_cr0); + vmx_set_cr0(vcpu, vmcs12->host_cr0); /* * If we did fpu_activate()/fpu_deactivate() during L2's run, we need * to apply the same changes to L1's vmcs. We just set cr0 correctly,