From patchwork Mon Jul 1 17:37:05 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andreas_F=C3=A4rber?= X-Patchwork-Id: 2809061 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 32A61BF4A1 for ; Mon, 1 Jul 2013 17:37:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 075C920134 for ; Mon, 1 Jul 2013 17:37:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0A74D20119 for ; Mon, 1 Jul 2013 17:37:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754821Ab3GARhO (ORCPT ); Mon, 1 Jul 2013 13:37:14 -0400 Received: from cantor2.suse.de ([195.135.220.15]:39951 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889Ab3GARhM (ORCPT ); Mon, 1 Jul 2013 13:37:12 -0400 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id E2513A535C; Mon, 1 Jul 2013 19:37:09 +0200 (CEST) Message-ID: <51D1BE41.40901@suse.de> Date: Mon, 01 Jul 2013 19:37:05 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Organization: SUSE LINUX Products GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130510 Thunderbird/17.0.6 MIME-Version: 1.0 To: Alexander Graf Cc: qemu-devel@nongnu.org, Peter Maydell , Anthony Liguori , Riku Voipio , Igor Mitsyanko , Mark Langsdorf , Evgeny Voevodin , Marcelo Tosatti , Gleb Natapov , Luiz Capitulino , Peter Crosthwaite , =?UTF-8?B?QW5kcmVhcw==?= =?UTF-8?B?IEbDpHJiZXI=?= , qemu-ppc , Paul Brook , David Gibson , kvm , "Edgar E. Iglesias" , Maksim Kozlov , Aurelien Jarno , Dmitry Solodkiy Subject: Re: [Qemu-devel] [PATCH qom-cpu v3 05/14] cpu: Make first_cpu and next_cpu CPUState References: <1372268143-3894-1-git-send-email-afaerber@suse.de> <1372268143-3894-6-git-send-email-afaerber@suse.de> In-Reply-To: <1372268143-3894-6-git-send-email-afaerber@suse.de> X-Enigmail-Version: 1.6a1pre Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Am 26.06.2013 19:35, schrieb Andreas Färber: > Move next_cpu from CPU_COMMON to CPUState. > Move first_cpu variable to qom/cpu.h. > > gdbstub needs to use CPUState::env_ptr for now. > cpu_copy() no longer needs to save and restore cpu_next. > > Acked-by: Paolo Bonzini > [AF: Rebased, simplified cpu_copy()] > Signed-off-by: Andreas Färber Squashing the following additional conversion after rebase. Andreas @@ -512,9 +511,7 @@ static DeviceState *ppce500_init_mpic_kvm(PPCE500Params *params, return NULL; } - for (env = first_cpu; env != NULL; env = env->next_cpu) { - cs = ENV_GET_CPU(env); - + for (cs = first_cpu; cs != NULL; cs = cs->next_cpu) { if (kvm_openpic_connect_vcpu(dev, cs)) { diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c index 38f7990..ff86154 100644 --- a/hw/ppc/e500.c +++ b/hw/ppc/e500.c @@ -500,7 +500,6 @@ static DeviceState *ppce500_init_mpic_kvm(PPCE500Params *params, qemu_irq **irqs) { DeviceState *dev; - CPUPPCState *env; CPUState *cs; int r;