From patchwork Thu Aug 8 21:13:41 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H. Peter Anvin" X-Patchwork-Id: 2841421 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 80975BF546 for ; Thu, 8 Aug 2013 21:22:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 895592038B for ; Thu, 8 Aug 2013 21:22:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A148120387 for ; Thu, 8 Aug 2013 21:22:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966704Ab3HHVVy (ORCPT ); Thu, 8 Aug 2013 17:21:54 -0400 Received: from terminus.zytor.com ([198.137.202.10]:38776 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966648Ab3HHVVx (ORCPT ); Thu, 8 Aug 2013 17:21:53 -0400 Received: from anacreon.sc.intel.com ([134.134.139.76]) (authenticated bits=0) by mail.zytor.com (8.14.5/8.14.5) with ESMTP id r78LDlEm012892 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Thu, 8 Aug 2013 14:15:25 -0700 Message-ID: <52040A05.5080107@zytor.com> Date: Thu, 08 Aug 2013 14:13:41 -0700 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Gleb Natapov CC: Konrad Rzeszutek Wilk , Raghavendra K T , mingo@redhat.com, jeremy@goop.org, x86@kernel.org, pbonzini@redhat.com, linux-doc@vger.kernel.org, habanero@linux.vnet.ibm.com, xen-devel@lists.xensource.com, peterz@infradead.org, mtosatti@redhat.com, stefano.stabellini@eu.citrix.com, andi@firstfloor.org, attilio.rao@citrix.com, ouyang@cs.pitt.edu, gregkh@suse.de, agraf@suse.de, chegu_vinod@hp.com, torvalds@linux-foundation.org, avi.kivity@gmail.com, tglx@linutronix.de, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, riel@redhat.com, drjones@redhat.com, virtualization@lists.linux-foundation.org, srivatsa.vaddagiri@gmail.com Subject: Re: [PATCH V12 0/14] Paravirtualized ticket spinlocks References: <20130806114020.20643.57235.sendpatchset@codeblue.in.ibm.com> <52016412.1020608@zytor.com> <5201B6FB.5080807@linux.vnet.ibm.com> <5201D180.9080005@zytor.com> <5201ED01.7000803@linux.vnet.ibm.com> <20130808005012.GI2810@phenom.dumpdata.com> <20130808010251.GJ15901@redhat.com> In-Reply-To: <20130808010251.GJ15901@redhat.com> X-Enigmail-Version: 1.5.2 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,KHOP_BIG_TO_CC, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 08/07/2013 06:02 PM, Gleb Natapov wrote: > On Wed, Aug 07, 2013 at 08:50:12PM -0400, Konrad Rzeszutek Wilk wrote: >> On Wed, Aug 07, 2013 at 12:15:21PM +0530, Raghavendra K T wrote: >>> On 08/07/2013 10:18 AM, H. Peter Anvin wrote: >>>>> Please let me know, if I should rebase again. >>>>> >>>> >>>> tip:master is not a stable branch; it is more like linux-next. We need >>>> to figure out which topic branches are dependencies for this set. >>> >>> Okay. I 'll start looking at the branches that would get affected. >>> (Xen, kvm are obvious ones). >>> Please do let me know the branches I might have to check for. >> >> >From the Xen standpoint anything past v3.11-rc4 would work. >> > For KVM as early as past v3.11-rc1 would be OK. > I'm still completely confused as to the base of this patchset. The first patch has the following hunk for arch/x86/include/asm/paravirt.h: { PVOP_VCALL2(pv_lock_ops.unlock_kick, lock, ticket); However, there is no ticket_unlock_kick in paravirt.h in either tip:master nor in linus... -hpa --- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- arch/x86/include/asm/paravirt.h +++ arch/x86/include/asm/paravirt.h @@ -718,7 +718,7 @@ PVOP_VCALLEE2(pv_lock_ops.lock_spinning, lock, ticket); } -static __always_inline void ____ticket_unlock_kick(struct arch_spinlock *lock, +static __always_inline void __ticket_unlock_kick(struct arch_spinlock *lock, __ticket_t ticket)