KVM: make halt_poll_ns static

Commit Message

Christian Borntraeger March 3, 2015, 9:46 p.m. UTC

Am 03.03.2015 um 22:42 schrieb Bandan Das:
> Christian Borntraeger <[e-mail]> writes:
> 
>> halt_poll_ns is used only locally. Make it static.
>>
>> Signed-off-by: Christian Borntraeger <[e-mail]>
>> ---
>>  virt/kvm/kvm_main.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
>> index 34310a8..58bc2a9 100644
>> --- a/virt/kvm/kvm_main.c
>> +++ b/virt/kvm/kvm_main.c
>> @@ -66,7 +66,7 @@
>>  MODULE_AUTHOR("Qumranet");
>>  MODULE_LICENSE("GPL");
>>  
>> -unsigned int halt_poll_ns = 0;
>> +static unsigned int halt_poll_ns = 0;
> 
> We should remove the initialization to zero. (Unfortunately,
> the usage pattern throughout the kernel code is not constant..)


Yes,

static unsigned int halt_poll_ns;

will do. 

Paolo, Marcelo,


I can add v2 to the next s390 pull request as below if you like.

halt_poll_ns is used only locally. Make it static and remove 
the initializer.



Otherwise I will resend.


to 

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Christian Borntraeger March 9, 2015, 12:15 p.m. UTC | #1

Am 03.03.2015 um 22:46 schrieb Christian Borntraeger:
[...]
> 
> halt_poll_ns is used only locally. Make it static and remove 
> the initializer.
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 34310a8..58bc2a9 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -66,7 +66,7 @@
>  MODULE_AUTHOR("Qumranet");
>  MODULE_LICENSE("GPL");
> 
> -unsigned int halt_poll_ns = 0;
> +static unsigned int halt_poll_ns;
>  module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
> 
>  /*
> 
> 
> Otherwise I will resend.

Ping. Do you want me to send that via my next pull request for s390 or shall I 
resend as a standalone patch for you to apply?

Christian

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to [e-mail]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
index 34310a8..58bc2a9 100644
--- a/virt/kvm/kvm_main.c
+++ b/virt/kvm/kvm_main.c
@@ -66,7 +66,7 @@ 
 MODULE_AUTHOR("Qumranet");
 MODULE_LICENSE("GPL");

-unsigned int halt_poll_ns = 0;
+static unsigned int halt_poll_ns;
 module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);

 /*