| Message ID | 5B13B2AF7C2779A7+20240916092857.433334-1-wangyuli@uniontech.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,6.10] LoongArch: KVM: Remove undefined a6 argument comment for kvm_hypercall() | expand |
On Mon, Sep 16, 2024 at 05:28:57PM +0800, WangYuli wrote: > From: Dandan Zhang <zhangdandan@uniontech.com> > > [ Upstream commit 494b0792d962e8efac72b3a5b6d9bcd4e6fa8cf0 ] > > The kvm_hypercall() set for LoongArch is limited to a1-a5. So the > mention of a6 in the comment is undefined that needs to be rectified. > > Reviewed-by: Bibo Mao <maobibo@loongson.cn> > Signed-off-by: Wentao Guan <guanwentao@uniontech.com> > Signed-off-by: Dandan Zhang <zhangdandan@uniontech.com> > Signed-off-by: Huacai Chen <chenhuacai@loongson.cn> > Signed-off-by: WangYuli <wangyuli@uniontech.com> > -- > Changlog: > *v1 -> v2: Correct the commit-msg format. > --- > arch/loongarch/include/asm/kvm_para.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/loongarch/include/asm/kvm_para.h b/arch/loongarch/include/asm/kvm_para.h > index 4ba2312e5f8c..6d5e9b6c5714 100644 > --- a/arch/loongarch/include/asm/kvm_para.h > +++ b/arch/loongarch/include/asm/kvm_para.h > @@ -28,9 +28,9 @@ > * Hypercall interface for KVM hypervisor > * > * a0: function identifier > - * a1-a6: args > + * a1-a5: args > * Return value will be placed in a0. > - * Up to 6 arguments are passed in a1, a2, a3, a4, a5, a6. > + * Up to 5 arguments are passed in a1, a2, a3, a4, a5. > */ > static __always_inline long kvm_hypercall0(u64 fid) > { > -- > 2.43.0 > > Again, why is this needed? thanks, greg k-h
On 2024/9/16 19:39, Greg KH wrote: > Again, why is this needed? > Hmm... Just a mini 'fix'. The reason of 'https://lore.kernel.org/all/2024091628-gigantic-filth-b7b7@gregkh' is same. > thanks, > > greg k-h > Thanks,
On Tue, Sep 17, 2024 at 04:49:04PM +0800, WangYuli wrote: > > On 2024/9/16 19:39, Greg KH wrote: > > Again, why is this needed? > > > Hmm... > > Just a mini 'fix'. > > The reason of > 'https://lore.kernel.org/all/2024091628-gigantic-filth-b7b7@gregkh' is same. It does not "fix" anything, please read the rules for what is allowed in a stable kernel in the documentation directory before submitting changes in the future. thanks, greg k-h
diff --git a/arch/loongarch/include/asm/kvm_para.h b/arch/loongarch/include/asm/kvm_para.h index 4ba2312e5f8c..6d5e9b6c5714 100644 --- a/arch/loongarch/include/asm/kvm_para.h +++ b/arch/loongarch/include/asm/kvm_para.h @@ -28,9 +28,9 @@ * Hypercall interface for KVM hypervisor * * a0: function identifier - * a1-a6: args + * a1-a5: args * Return value will be placed in a0. - * Up to 6 arguments are passed in a1, a2, a3, a4, a5, a6. + * Up to 5 arguments are passed in a1, a2, a3, a4, a5. */ static __always_inline long kvm_hypercall0(u64 fid) {