From patchwork Sat Oct 28 18:13:38 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Gerhard Wiesinger X-Patchwork-Id: 10031087 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 86510602D6 for ; Sat, 28 Oct 2017 18:21:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 80C4428871 for ; Sat, 28 Oct 2017 18:21:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 752DE288FC; Sat, 28 Oct 2017 18:21:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E2F1728871 for ; Sat, 28 Oct 2017 18:21:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751566AbdJ1SU6 (ORCPT ); Sat, 28 Oct 2017 14:20:58 -0400 Received: from vps01.wiesinger.com ([46.36.37.179]:33230 "EHLO vps01.wiesinger.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751560AbdJ1SU5 (ORCPT ); Sat, 28 Oct 2017 14:20:57 -0400 X-Greylist: delayed 420 seconds by postgrey-1.27 at vger.kernel.org; Sat, 28 Oct 2017 14:20:57 EDT Received: from wiesinger.com (wiesinger.com [84.113.44.87]) by vps01.wiesinger.com (Postfix) with ESMTPS id 1732A9F16E; Sat, 28 Oct 2017 20:13:54 +0200 (CEST) Received: from [192.168.32.242] (89-104-7-101.customer.bnet.at [89.104.7.101]) (authenticated bits=0) by wiesinger.com (8.15.2/8.15.2) with ESMTPSA id v9SIDcNM004726 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 28 Oct 2017 20:13:41 +0200 DKIM-Filter: OpenDKIM Filter v2.11.0 wiesinger.com v9SIDcNM004726 Subject: Re: [Qemu-devel] kvm_intel fails to load on Conroe CPUs running Linux 4.12 To: Paolo Bonzini Cc: KVM list , qemu-devel@nongnu.org References: <35eda6a9-086e-f899-e131-288f2346effe@wiesinger.com> <3e1f41a8-faff-1858-6f0d-154694dff02d@wiesinger.com> <0e69cbad-f658-03be-0191-1b6fe588147b@wiesinger.com> <1b37b04c-349f-28f7-fb6c-fbbbe8415b33@wiesinger.com> <7757e373-c892-2824-d710-27ca57d479c4@redhat.com> From: Gerhard Wiesinger Message-ID: <62d3868d-a2dd-d606-f1f1-1c05174c4b57@wiesinger.com> Date: Sat, 28 Oct 2017 20:13:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-MailScanner-Information-wiesinger-com: Please contact the ISP for more information X-yoursite-MailScanner-ID: v9SIDcNM004726 X-MailScanner-wiesinger-com: Found to be clean X-MailScanner-SpamCheck-wiesinger-com: spam, JUSTSPAM, SpamAssassin (not cached, score=-0.999, required 4.5, autolearn=not spam, ALL_TRUSTED -1.00, URIBL_BLOCKED 0.00) X-yoursite-MailScanner-From: lists@wiesinger.com Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 10.10.2017 16:16, Paolo Bonzini wrote: > On 27/09/2017 21:31, Gerhard Wiesinger wrote: >> On 15.09.2017 19:07, Paolo Bonzini wrote: >>> On 15/09/2017 16:43, Gerhard Wiesinger wrote: >>>> On 27.08.2017 20:55, Paolo Bonzini wrote: >>>>> Il 27 ago 2017 4:48 PM, "Gerhard Wiesinger" >>>> > ha scritto: >>>>> >>>>>      On 27.08.2017 14 :03, Paolo Bonzini wrote: >>>>> >>>>> >>>>>          We will revert the patch, but 4.13.0 will not have the fix. >>>>>          Expect it in later stable kernels (because vacations). >>>>> >>>>> >>>>>      Thnx. Why will 4.13.0 NOT have the fix? >>>>> >>>>> >>>>> Because maintainers are on vacation! :-) >>>>> >>>>> >>>> Hello Paolo, >>>> >>>> Any update on this for 4.12 and 4.13 kernels? >>> A late fix is better than a wrong fix.  Hope to get to it next week! >> Hello Paolo, >> >> Any update? Thnx. > Hey, I have a patch now. Any volunteers for testing it? > > This is on top of 4.13. > > Paolo > > diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c > index c6ef2940119b..c29bf36485fd 100644 > --- a/arch/x86/kvm/vmx.c > +++ b/arch/x86/kvm/vmx.c > @@ -200,6 +200,10 @@ struct loaded_vmcs { > int cpu; > bool launched; > bool nmi_known_unmasked; > + /* Support for vnmi-less CPUs */ > + int soft_vnmi_blocked; > + ktime_t entry_time; > + s64 vnmi_blocked_time; > struct list_head loaded_vmcss_on_cpu_link; > }; > Hello Paolo, The patch does not apply, 1st hunk FAILED. cat arch/x86/kvm/vmx.c.rej Tried it to apply against, doesn't look to fit: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/tree/arch/x86/kvm/vmx.c?h=v4.13.10#n197 https://koji.fedoraproject.org/koji/buildinfo?buildID=991441 Will then recompile and test. Thnx. Ciao, Gerhard --- arch/x86/kvm/vmx.c +++ arch/x86/kvm/vmx.c @@ -200,6 +200,10 @@ struct loaded_vmcs {         int cpu;         bool launched;         bool nmi_known_unmasked; +       /* Support for vnmi-less CPUs */ +       int soft_vnmi_blocked; +       ktime_t entry_time; +       s64 vnmi_blocked_time;         struct list_head loaded_vmcss_on_cpu_link;  };