| Message ID | 6cf36937-3937-0521-5f11-258f557e0c32@users.sourceforge.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
> From: Markus Elfring <elfring@users.sourceforge.net> > Date: Wed, 17 Aug 2016 19:28:15 +0200 > > The variable "bp_data" will eventually be set to an appropriate pointer > from a call of the memdup_user() function. > Thus omit the explicit initialisation which became unnecessary with > a previous update step. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Looks sane to me. Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com> Thanks! David -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 17 Aug 2016 20:12:15 +0200 SF Markus Elfring <elfring@users.sourceforge.net> wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Wed, 17 Aug 2016 19:28:15 +0200 > > The variable "bp_data" will eventually be set to an appropriate pointer > from a call of the memdup_user() function. > Thus omit the explicit initialisation which became unnecessary with > a previous update step. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > arch/s390/kvm/guestdbg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/s390/kvm/guestdbg.c b/arch/s390/kvm/guestdbg.c > index f2514af..ad04609 100644 > --- a/arch/s390/kvm/guestdbg.c > +++ b/arch/s390/kvm/guestdbg.c > @@ -207,7 +207,7 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, > struct kvm_guest_debug *dbg) > { > int ret = 0, nr_wp = 0, nr_bp = 0, i, size; > - struct kvm_hw_breakpoint *bp_data = NULL; > + struct kvm_hw_breakpoint *bp_data; > struct kvm_hw_wp_info_arch *wp_info = NULL; > struct kvm_hw_bp_info_arch *bp_info = NULL; > NACK. -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/s390/kvm/guestdbg.c b/arch/s390/kvm/guestdbg.c index f2514af..ad04609 100644 --- a/arch/s390/kvm/guestdbg.c +++ b/arch/s390/kvm/guestdbg.c @@ -207,7 +207,7 @@ int kvm_s390_import_bp_data(struct kvm_vcpu *vcpu, struct kvm_guest_debug *dbg) { int ret = 0, nr_wp = 0, nr_bp = 0, i, size; - struct kvm_hw_breakpoint *bp_data = NULL; + struct kvm_hw_breakpoint *bp_data; struct kvm_hw_wp_info_arch *wp_info = NULL; struct kvm_hw_bp_info_arch *bp_info = NULL;