diff mbox

[3/3,RESEND] kvm: qemu: fix double removal of assigned device

Message ID 715D42877B251141A38726ABF5CABF2C01957E5A52@pdsmsx503.ccr.corp.intel.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Han, Weidong Feb. 6, 2009, 8:58 a.m. UTC
free_assigned_device removes the assigned device from the
list adev_head, needn't remove it in assigned_dev_update_irqs.

Signed-off-by: Weidong Han <weidong.han@intel.com>
---
 qemu/hw/device-assignment.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

Comments

Mark McLoughlin Feb. 6, 2009, 10:16 a.m. UTC | #1
On Fri, 2009-02-06 at 16:58 +0800, Han, Weidong wrote:
> free_assigned_device removes the assigned device from the
> list adev_head, needn't remove it in assigned_dev_update_irqs.
> 
> Signed-off-by: Weidong Han <weidong.han@intel.com>

Acked-by: Mark McLoughlin <markmc@redhat.com>

Cheers,
Mark.

--
To unsubscribe from this list: send the line "unsubscribe kvm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/qemu/hw/device-assignment.c b/qemu/hw/device-assignment.c
index 82ff00a..e6d2352 100644
--- a/qemu/hw/device-assignment.c
+++ b/qemu/hw/device-assignment.c
@@ -522,7 +522,6 @@  void assigned_dev_update_irqs()
                         adev->name, strerror(-r));
                 fprintf(stderr, "Perhaps you are assigning a device "
                         "that shares an IRQ with another device?\n");
-                LIST_REMOVE(adev, next);
                 free_assigned_device(adev);
                 adev = next;
                 continue;