| Message ID | 7adb093f872ead3f69c03dcc26a15fb9d1c499f2.1637799475.git.isaku.yamahata@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | KVM: X86: TDX support | expand |
On Wed, Nov 24 2021 at 16:19, isaku yamahata wrote: What is PV MMIO? This has nothing to do with PV=, aka paravirt because it's used in the tdx exit handler for emulation. Please stop confusing concepts. > From: Sean Christopherson <sean.j.christopherson@intel.com> > > Later kvm_intel.ko will use it. That sentence is useless, as are the other 'later patches' phrases all over the place. At submission time it's obvious and once this is merged it's not helpful at all. What's even worse is that this happens right at the beginning of the series and the actual use case is introduced 50 patches later. That's not how exports are done. Exports are next to the use case and in the best case they can be just part of the use case patch. This is not how fine granular patching works. Just splitting out stupid things into separate patches does not make a proper patch series. It creates an illusion, that's it. And if I look at the patch which makes actual use of that export then it's just the proof. I'll come to that later. Thanks, tglx
diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index d31724500501..d8e799eeef8d 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -4994,6 +4994,7 @@ int kvm_io_bus_read(struct kvm_vcpu *vcpu, enum kvm_bus bus_idx, gpa_t addr, r = __kvm_io_bus_read(vcpu, bus, &range, val); return r < 0 ? r : 0; } +EXPORT_SYMBOL_GPL(kvm_io_bus_read); /* Caller must hold slots_lock. */ int kvm_io_bus_register_dev(struct kvm *kvm, enum kvm_bus bus_idx, gpa_t addr,