From patchwork Mon Jan 14 15:40:28 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoffer Dall X-Patchwork-Id: 1972581 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id C6E583FE33 for ; Mon, 14 Jan 2013 15:40:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757052Ab3ANPka (ORCPT ); Mon, 14 Jan 2013 10:40:30 -0500 Received: from mail-vb0-f45.google.com ([209.85.212.45]:40068 "EHLO mail-vb0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757047Ab3ANPk3 (ORCPT ); Mon, 14 Jan 2013 10:40:29 -0500 Received: by mail-vb0-f45.google.com with SMTP id p1so3623303vbi.4 for ; Mon, 14 Jan 2013 07:40:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-originating-ip:in-reply-to:references:date :message-id:subject:from:to:cc:content-type:x-gm-message-state; bh=nknU6YLZ/5d3x3+s0mfblfsl5yPYTA1XR4c97iAx5jk=; b=FjKPfzmTFOIMv+z/0cG+9Q+GuVnD4c4+1YdG3YhETHeNGE7xEanfpH/bfwUAZrGztK swPwYiJUEFsTgoFfEpALnseMwiPjdUD0t5fkQQ6JtT7pqi0jXvw3v+d1CE77C0OFB+Jc hDD3K1PYbx9FDE5vheYKm7flUafUJP8e/Pjzkd4Ax46ahuuT6IMMhsdzxq5CDIqemVjT BW59NGqkMSBXBnY5RAlCuU7x53GDowX+AWob58aCcB08IJ0qyH0f/xyrM89n46GPtX7c KnZ/ah2atrhWi6XN4cK4Lq1zr3tCGIt1P6KQP0kB/uHrnnqtKYELTtfrg4XHUwvwd6LH rVkw== MIME-Version: 1.0 Received: by 10.58.168.135 with SMTP id zw7mr103919339veb.4.1358178028858; Mon, 14 Jan 2013 07:40:28 -0800 (PST) Received: by 10.221.7.71 with HTTP; Mon, 14 Jan 2013 07:40:28 -0800 (PST) X-Originating-IP: [72.80.83.148] In-Reply-To: <20130114150917.GA18935@mudshark.cambridge.arm.com> References: <20130108183811.46302.58543.stgit@ubuntu> <20130108183855.46302.40539.stgit@ubuntu> <20130114150917.GA18935@mudshark.cambridge.arm.com> Date: Mon, 14 Jan 2013 10:40:28 -0500 Message-ID: Subject: Re: [PATCH v5 03/14] KVM: ARM: Initial skeleton to compile KVM support From: Christoffer Dall To: Will Deacon Cc: "kvm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "kvmarm@lists.cs.columbia.edu" , Marc Zyngier , Marcelo Tosatti , Rusty Russell X-Gm-Message-State: ALoCoQmiKWx4rOMcgiYBttifXnWSQ0mgnVKBYr/rhWuHQgM3beeWhaftd9uq2/IJfgTh/vq4VdDA Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Mon, Jan 14, 2013 at 10:09 AM, Will Deacon wrote: > On Tue, Jan 08, 2013 at 06:38:55PM +0000, Christoffer Dall wrote: >> Targets KVM support for Cortex A-15 processors. >> >> Contains all the framework components, make files, header files, some >> tracing functionality, and basic user space API. >> >> Only supported core is Cortex-A15 for now. >> >> Most functionality is in arch/arm/kvm/* or arch/arm/include/asm/kvm_*.h. >> >> Reviewed-by: Marcelo Tosatti >> Signed-off-by: Rusty Russell >> Signed-off-by: Marc Zyngier >> Signed-off-by: Christoffer Dall >> --- >> Documentation/virtual/kvm/api.txt | 57 +++++- >> arch/arm/Kconfig | 2 >> arch/arm/Makefile | 1 >> arch/arm/include/asm/kvm_arm.h | 24 ++ >> arch/arm/include/asm/kvm_asm.h | 58 ++++++ >> arch/arm/include/asm/kvm_coproc.h | 24 ++ >> arch/arm/include/asm/kvm_emulate.h | 50 +++++ >> arch/arm/include/asm/kvm_host.h | 114 ++++++++++++ >> arch/arm/include/uapi/asm/kvm.h | 106 +++++++++++ > > [...] > >> diff --git a/arch/arm/include/uapi/asm/kvm.h b/arch/arm/include/uapi/asm/kvm.h >> new file mode 100644 >> index 0000000..c6298b1 >> --- /dev/null >> +++ b/arch/arm/include/uapi/asm/kvm.h >> @@ -0,0 +1,106 @@ >> +/* >> + * Copyright (C) 2012 - Virtual Open Systems and Columbia University >> + * Author: Christoffer Dall >> + * >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License, version 2, as >> + * published by the Free Software Foundation. >> + * >> + * This program is distributed in the hope that it will be useful, >> + * but WITHOUT ANY WARRANTY; without even the implied warranty of >> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >> + * GNU General Public License for more details. >> + * >> + * You should have received a copy of the GNU General Public License >> + * along with this program; if not, write to the Free Software >> + * Foundation, 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. >> + */ >> + >> +#ifndef __ARM_KVM_H__ >> +#define __ARM_KVM_H__ >> + >> +#include >> +#include > > I think you want linux/types.h, as asm/types.h isn't exported from what I > can tell. make headers_check screams about it too: > > /home/will/sources/linux/linux/usr/include/asm/kvm.h:22: include of is preferred over > /home/will/sources/linux/linux/usr/include/asm/kvm.h:57: found __[us]{8,16,32,64} type without #include > right, fixed: commit 4f880a3224b26a854736f19b21de9d457829940e Author: Christoffer Dall Date: Mon Jan 14 10:39:03 2013 -0500 KVM: ARM: Include linux/types.h instead of asm/types.h Include the right header file. Cc: Will Deacon Signed-off-by: Christoffer Dall --- Thanks, -Christoffer -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/include/uapi/asm/kvm.h b/arch/arm/include/uapi/asm/kvm.h index 972b90d..236f528 100644 --- a/arch/arm/include/uapi/asm/kvm.h +++ b/arch/arm/include/uapi/asm/kvm.h @@ -19,7 +19,7 @@ #ifndef __ARM_KVM_H__ #define __ARM_KVM_H__ -#include +#include #include #define __KVM_HAVE_GUEST_DEBUG