[RESEND,v2] kvm: mmu: fix typos in struct kvm_arch

Commit Message

Hao Peng Sept. 23, 2022, 3:05 p.m. UTC

From: Peng Hao <[e-mail]>

No 'kvmp_mmu_pages', it should be 'kvm_mmu_page'. And
struct kvm_mmu_pages and struct kvm_mmu_page are different structures,
here should be kvm_mmu_page.
kvm_mmu_pages is defined in arch/x86/kvm/mmu/mmu.c.

Suggested-by: David Matlack <[e-mail]>
Signed-off-by: Peng Hao <[e-mail]>
Reviewed-by: David Matlack <[e-mail]>
---
arch/x86/include/asm/kvm_host.h | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

--
2.27.0

Comments

Paolo Bonzini Sept. 27, 2022, 2:18 p.m. UTC | #1

On 9/23/22 17:05, Hao Peng wrote:
> From: Peng Hao<[e-mail]>
> 
> No 'kvmp_mmu_pages', it should be 'kvm_mmu_page'. And
> struct kvm_mmu_pages and struct kvm_mmu_page are different structures,
> here should be kvm_mmu_page.
> kvm_mmu_pages is defined in arch/x86/kvm/mmu/mmu.c.
> 
> Suggested-by: David Matlack<[e-mail]>
> Signed-off-by: Peng Hao<[e-mail]>
> Reviewed-by: David Matlack<[e-mail]>
> ---
> arch/x86/include/asm/kvm_host.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)

Queued, but the patch was broken (it had spaces instead of tabs for 
indentation).

Paolo

Patch

diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
index e8281d64a431..e67b2f602fb2 100644
--- a/arch/x86/include/asm/kvm_host.h
+++ b/arch/x86/include/asm/kvm_host.h
@@ -1272,8 +1272,8 @@  struct kvm_arch {
        bool tdp_mmu_enabled;

        /*
-        * List of struct kvm_mmu_pages being used as roots.
-        * All struct kvm_mmu_pages in the list should have
+        * List of kvm_mmu_page structs being used as roots.
+        * All kvm_mmu_page structs in the list should have
         * tdp_mmu_page set.
         *
         * For reads, this list is protected by:
@@ -1292,8 +1292,8 @@  struct kvm_arch {
        struct list_head tdp_mmu_roots;

        /*
-        * List of struct kvmp_mmu_pages not being used as roots.
-        * All struct kvm_mmu_pages in the list should have
+        * List of kvm_mmu_page structs not being used as roots.
+        * All kvm_mmu_page structs in the list should have
         * tdp_mmu_page set and a tdp_mmu_root_count of 0.
         */
        struct list_head tdp_mmu_pages;
@@ -1303,9 +1303,9 @@  struct kvm_arch {
         * is held in read mode:
         *  - tdp_mmu_roots (above)
         *  - tdp_mmu_pages (above)
-        *  - the link field of struct kvm_mmu_pages used by the TDP MMU
+        *  - the link field of kvm_mmu_page structs used by the TDP MMU
         *  - lpage_disallowed_mmu_pages
-        *  - the lpage_disallowed_link field of struct kvm_mmu_pages used
+        *  - the lpage_disallowed_link field of kvm_mmu_page structs used
         *    by the TDP MMU
         * It is acceptable, but not necessary, to acquire this lock when
         * the thread holds the MMU lock in write mode.