x86/sev: Remove do_early_exception() forward declarations

Commit Message

Borislav Petkov Aug. 23, 2021, 7:45 p.m. UTC

On Mon, Aug 23, 2021 at 01:56:06PM -0500, Brijesh Singh wrote:
> thanks, I will merge this in next version.

Thx.

One more thing I stumbled upon while staring at this, see below. Can you
add it to your set or should I simply apply it now?

Thx.

---
From: Borislav Petkov <[e-mail]>
Date: Mon, 23 Aug 2021 20:01:35 +0200
Subject: [PATCH] x86/sev: Remove do_early_exception() forward declarations

There's a perfectly fine prototype in the asm/setup.h header. Use it.

No functional changes.

Signed-off-by: Borislav Petkov <[e-mail]>
---
 arch/x86/kernel/sev.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Brijesh Singh Aug. 23, 2021, 8:06 p.m. UTC | #1

On 8/23/21 2:45 PM, Borislav Petkov wrote:
> On Mon, Aug 23, 2021 at 01:56:06PM -0500, Brijesh Singh wrote:
>> thanks, I will merge this in next version.
> 
> Thx.
> 
> One more thing I stumbled upon while staring at this, see below. Can you
> add it to your set or should I simply apply it now?
> 

I can include it in my series. thanks

Patch

diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c
index a6895e440bc3..700ef31d32f8 100644
--- a/arch/x86/kernel/sev.c
+++ b/arch/x86/kernel/sev.c
@@ -26,6 +26,7 @@ 
 #include <asm/fpu/internal.h>
 #include <asm/processor.h>
 #include <asm/realmode.h>
+#include <asm/setup.h>
 #include <asm/traps.h>
 #include <asm/svm.h>
 #include <asm/smp.h>
@@ -96,9 +97,6 @@  struct ghcb_state {
 static DEFINE_PER_CPU(struct sev_es_runtime_data*, runtime_data);
 DEFINE_STATIC_KEY_FALSE(sev_es_enable_key);
 
-/* Needed in vc_early_forward_exception */
-void do_early_exception(struct pt_regs *regs, int trapnr);
-
 static void __init setup_vc_stacks(int cpu)
 {
 	struct sev_es_runtime_data *data;
@@ -240,9 +238,6 @@  static noinstr struct ghcb *__sev_get_ghcb(struct ghcb_state *state)
 	return ghcb;
 }
 
-/* Needed in vc_early_forward_exception */
-void do_early_exception(struct pt_regs *regs, int trapnr);
-
 static inline u64 sev_es_rd_ghcb_msr(void)
 {
 	return __rdmsr(MSR_AMD64_SEV_ES_GHCB);