From patchwork Thu Apr 28 08:59:52 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 738721 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id p3S90BBD016669 for ; Thu, 28 Apr 2011 09:00:12 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757583Ab1D1JAH (ORCPT ); Thu, 28 Apr 2011 05:00:07 -0400 Received: from david.siemens.de ([192.35.17.14]:27003 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757443Ab1D1JAF (ORCPT ); Thu, 28 Apr 2011 05:00:05 -0400 Received: from mail1.siemens.de (localhost [127.0.0.1]) by david.siemens.de (8.13.6/8.13.6) with ESMTP id p3S8xsm7025140; Thu, 28 Apr 2011 10:59:55 +0200 Received: from mchn199C.mchp.siemens.de ([139.25.109.49]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id p3S8xspZ021662; Thu, 28 Apr 2011 10:59:54 +0200 From: Jan Kiszka To: Avi Kivity , Marcelo Tosatti Cc: kvm@vger.kernel.org, Alex Williamson Subject: [PATCH 4/5] pci-assign: Remove suspicious hunk from assigned_dev_pci_read_config Date: Thu, 28 Apr 2011 10:59:52 +0200 Message-Id: X-Mailer: git-send-email 1.7.1 In-Reply-To: References: In-Reply-To: References: Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter1.kernel.org [140.211.167.41]); Thu, 28 Apr 2011 09:00:14 +0000 (UTC) No one can remember where this came from, and it looks very hacky anyway (we return 0 for config space address 0xfc of _every_ assigned device, not only vga as the comment claims). So better remove it and wait for the underlying issue to reappear. Signed-off-by: Jan Kiszka --- hw/device-assignment.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/hw/device-assignment.c b/hw/device-assignment.c index ee81434..7ff1320 100644 --- a/hw/device-assignment.c +++ b/hw/device-assignment.c @@ -496,10 +496,6 @@ static uint32_t assigned_dev_pci_read_config(PCIDevice *d, uint32_t address, return val; } - /* vga specific, remove later */ - if (address == 0xFC) - goto do_log; - fd = pci_dev->real_device.config_fd; again: @@ -514,7 +510,6 @@ again: exit(1); } -do_log: DEBUG("(%x.%x): address=%04x val=0x%08x len=%d\n", (d->devfn >> 3) & 0x1F, (d->devfn & 0x7), address, val, len);