From patchwork Thu Aug 16 13:54:32 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Kiszka X-Patchwork-Id: 1332221 Return-Path: X-Original-To: patchwork-kvm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 31A8D40210 for ; Thu, 16 Aug 2012 13:56:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932582Ab2HPN4A (ORCPT ); Thu, 16 Aug 2012 09:56:00 -0400 Received: from david.siemens.de ([192.35.17.14]:34083 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757104Ab2HPNyl (ORCPT ); Thu, 16 Aug 2012 09:54:41 -0400 Received: from mail1.siemens.de (localhost [127.0.0.1]) by david.siemens.de (8.13.6/8.13.6) with ESMTP id q7GDsZSf007038; Thu, 16 Aug 2012 15:54:35 +0200 Received: from mchn199C.mchp.siemens.de ([139.25.109.49]) by mail1.siemens.de (8.13.6/8.13.6) with ESMTP id q7GDsYJS012893; Thu, 16 Aug 2012 15:54:35 +0200 From: Jan Kiszka To: Avi Kivity , Marcelo Tosatti Cc: kvm@vger.kernel.org, Alex Williamson Subject: [PATCH 18/19] pci-assign: Drop unused or write-only variables Date: Thu, 16 Aug 2012 15:54:32 +0200 Message-Id: X-Mailer: git-send-email 1.7.3.4 In-Reply-To: References: In-Reply-To: References: Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Remove remainders of previous refactorings. Signed-off-by: Jan Kiszka --- hw/kvm/pci-assign.c | 9 --------- 1 files changed, 0 insertions(+), 9 deletions(-) diff --git a/hw/kvm/pci-assign.c b/hw/kvm/pci-assign.c index 29a4671..4f5daf3 100644 --- a/hw/kvm/pci-assign.c +++ b/hw/kvm/pci-assign.c @@ -120,13 +120,10 @@ typedef struct AssignedDevice { uint32_t dev_id; uint32_t features; int intpin; - uint8_t debug_flags; AssignedDevRegion v_addrs[PCI_NUM_REGIONS - 1]; PCIDevRegions real_device; - int run; PCIINTxRoute intx_route; AssignedIRQType assigned_irq_type; - int bound; struct { #define ASSIGNED_DEVICE_CAP_MSI (1 << 0) #define ASSIGNED_DEVICE_CAP_MSIX (1 << 1) @@ -146,7 +143,6 @@ typedef struct AssignedDevice { MemoryRegion mmio; char *configfd_name; int32_t bootindex; - QLIST_ENTRY(AssignedDevice) next; } AssignedDevice; static void assigned_dev_update_irq_routing(PCIDevice *dev); @@ -699,8 +695,6 @@ again: return 0; } -static QLIST_HEAD(, AssignedDevice) devs = QLIST_HEAD_INITIALIZER(devs); - static void free_msi_virqs(AssignedDevice *dev) { int i; @@ -1767,7 +1761,6 @@ static int assigned_initfn(struct PCIDevice *pci_dev) /* handle interrupt routing */ e_intx = dev->dev.config[0x3d] - 1; dev->intpin = e_intx; - dev->run = 0; dev->intx_route.mode = PCI_INTX_DISABLED; dev->intx_route.irq = -1; @@ -1784,7 +1777,6 @@ static int assigned_initfn(struct PCIDevice *pci_dev) } assigned_dev_load_option_rom(dev); - QLIST_INSERT_HEAD(&devs, dev, next); add_boot_device_path(dev->bootindex, &pci_dev->qdev, NULL); @@ -1801,7 +1793,6 @@ static void assigned_exitfn(struct PCIDevice *pci_dev) { AssignedDevice *dev = DO_UPCAST(AssignedDevice, dev, pci_dev); - QLIST_REMOVE(dev, next); deassign_device(dev); free_assigned_device(dev); }