From patchwork Tue Jan 19 21:11:30 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dustin Kirkland X-Patchwork-Id: 73942 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter.kernel.org (8.14.3/8.14.2) with ESMTP id o0JLBaZr008557 for ; Tue, 19 Jan 2010 21:11:36 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755673Ab0ASVLd (ORCPT ); Tue, 19 Jan 2010 16:11:33 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755681Ab0ASVLd (ORCPT ); Tue, 19 Jan 2010 16:11:33 -0500 Received: from mail-fx0-f215.google.com ([209.85.220.215]:50819 "EHLO mail-fx0-f215.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755660Ab0ASVLc (ORCPT ); Tue, 19 Jan 2010 16:11:32 -0500 Received: by fxm7 with SMTP id 7so31263fxm.28 for ; Tue, 19 Jan 2010 13:11:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:received:in-reply-to :references:date:x-google-sender-auth:message-id:subject:from:to:cc :content-type; bh=k+OPKWUSNfeX4s8G83IP0vQhWMretHNi42y754qNywE=; b=DamWTqYeGo4YLTahgvjTTGEK4ApP/5D14Dj5SQyFUsJwfqqPre7v+7TkhAuNv7C6cP ZQjBPBoQVMRgUtP/Fh1nxBuTY+byiC4J1PVgtaRSIV+rxIgbLL3Q+auzMEwLtPqeJ6x/ lzYO+wG7oYQPTHFp6C6Fu9lCmdSd7u4p8U6PE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; b=VciiFmzdoXhc+OQnN7OzHhZnxP/dw3SvBCW51lvwu4KQ+cTI95Nrd5pgBAfo9B6XbM wEA51TCdRr9/bCIgzxHy8FcBc1uTrLw6G3BusvdXgj/ZNX6w6NYqxz/g7gaBssnO14bH 57vGwbCT22XxjaFJf/2IX+VYWSnX982l1QeA4= MIME-Version: 1.0 Received: by 10.223.5.65 with SMTP id 1mr1060999fau.77.1263935490437; Tue, 19 Jan 2010 13:11:30 -0800 (PST) In-Reply-To: <20100119173121.GA11561@x200.localdomain> References: <20100119173121.GA11561@x200.localdomain> Date: Wed, 20 Jan 2010 10:11:30 +1300 X-Google-Sender-Auth: e42783c39b3fdd64 Message-ID: Subject: Re: KVM developer call minutes (Jan 19) From: Dustin Kirkland To: Chris Wright Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org qemu-img: improve error reporting Use strerror to provide a better error message when qemu-img fails. https://bugs.edge.launchpad.net/ubuntu/+source/qemu-kvm/+bug/418112 Signed-off-by: Dustin Kirkland diff -uprN qemu-kvm-0.11.0~rc2/qemu-img.c qemu-kvm-0.11.0~rc2.new/qemu-img.c --- qemu-kvm-0.11.0~rc2/qemu-img.c 2009-08-30 04:10:59.000000000 -0500 +++ qemu-kvm-0.11.0~rc2.new/qemu-img.c 2009-09-10 22:30:32.572211443 -0500 @@ -368,7 +368,7 @@ static int img_create(int argc, char **a } else if (ret == -EFBIG) { error("The image size is too large for file format '%s'", fmt); } else { - error("Error while formatting"); + error("Error while formatting (%s)", strerror(-ret)); } } return 0;