diff mbox series

SVM: Fix warnings in svm.h

Message ID e541a2b2fe55ade4277f34fa64953683@208suo.com (mailing list archive)
State New, archived
Headers show
Series SVM: Fix warnings in svm.h | expand

Commit Message

huzhi001@208suo.com July 12, 2023, 1:39 p.m. UTC 
The following checkpatch warnings are removed:
WARNING: Prefer __packed over __attribute__((__packed__))

Signed-off-by: ZhiHu <huzhi001@208suo.com>
---
  arch/x86/include/asm/svm.h | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Peter Zijlstra July 12, 2023, 1:59 p.m. UTC | #1 
On Wed, Jul 12, 2023 at 09:39:24PM +0800, huzhi001@208suo.com wrote:
> The following checkpatch warnings are removed:
> WARNING: Prefer __packed over __attribute__((__packed__))

Can you please stop with these pointless checkpatch things?
Randy Dunlap July 12, 2023, 3:05 p.m. UTC | #2 
On 7/12/23 06:59, Peter Zijlstra wrote:
> On Wed, Jul 12, 2023 at 09:39:24PM +0800, huzhi001@208suo.com wrote:
>> The following checkpatch warnings are removed:
>> WARNING: Prefer __packed over __attribute__((__packed__))
> 
> Can you please stop with these pointless checkpatch things?

We should probably document that checkpatch should usually just be used
on patches and not on entire files.
diff mbox series

Patch

diff --git a/arch/x86/include/asm/svm.h b/arch/x86/include/asm/svm.h
index e7c7379d6ac7..7ecebccf8a83 100644
--- a/arch/x86/include/asm/svm.h
+++ b/arch/x86/include/asm/svm.h
@@ -119,7 +119,7 @@  enum {
  };

-struct __attribute__ ((__packed__)) vmcb_control_area {
+struct __packed vmcb_control_area {
      u32 intercepts[MAX_INTERCEPT];
      u32 reserved_1[15 - MAX_INTERCEPT];
      u16 pause_filter_thresh;