From patchwork Tue Aug 15 17:18:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Isaku Yamahata X-Patchwork-Id: 13353993 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19FDCC04A6A for ; Tue, 15 Aug 2023 17:20:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238720AbjHORTh (ORCPT ); Tue, 15 Aug 2023 13:19:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238705AbjHORTM (ORCPT ); Tue, 15 Aug 2023 13:19:12 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D40651BC7; Tue, 15 Aug 2023 10:19:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692119951; x=1723655951; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=BoNjcydlwVP9IfhBLhVhZL9vVzO2yH4AyILTumiROh0=; b=QdtnaR9t0YnmjwpFejUdWX6A2J9/iu39WM7TOCdaC618aeEj8+1VErZJ TEFu1TV0RfUppsvS2BBdBO9WuR0GsM1vvb5qoUfCEfyGz2AFUNzxsT1CP cfaDg/MrdG/Ruo7wsr1iKUG4CQPUKSBszTlucG/Ul6jgyes3ij3Pcw/FJ ciJ3NiQpgqBYA98Q1QguN6Clbs0KPy1+12nEoYliUvl/rBIT8nGTH2iWi tT1YrL9uJWfrvSowcYGrn/Kl1d6c0CYkCZrvm5iu/tUyidCdrTJcyt3Fr AE6DzXDuE7XkOkpbYJYyg4tsqHyBNrAXET7ppZXRyifVuhPExEgebQp0J w==; X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="362488586" X-IronPort-AV: E=Sophos;i="6.01,175,1684825200"; d="scan'208";a="362488586" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2023 10:19:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="848148968" X-IronPort-AV: E=Sophos;i="6.01,175,1684825200"; d="scan'208";a="848148968" Received: from ls.sc.intel.com (HELO localhost) ([172.25.112.31]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2023 10:19:04 -0700 From: isaku.yamahata@intel.com To: kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: isaku.yamahata@intel.com, isaku.yamahata@gmail.com, Michael Roth , Paolo Bonzini , Sean Christopherson , erdemaktas@google.com, Sagi Shahar , David Matlack , Kai Huang , Zhi Wang , chen.bo@intel.com, linux-coco@lists.linux.dev, Chao Peng , Ackerley Tng , Vishal Annapurve , Yuan Yao , Jarkko Sakkinen , Xu Yilun , Quentin Perret , wei.w.wang@intel.com, Fuad Tabba Subject: [PATCH 1/8] KVM: gmem: Make kvm_gmem_bind return EBADF on wrong fd Date: Tue, 15 Aug 2023 10:18:48 -0700 Message-Id: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org From: Isaku Yamahata When kvm_gmem_bind() fails fget(), return EBADF instead of EINVAL because EBADF is more appropriate. Signed-off-by: Isaku Yamahata --- virt/kvm/guest_mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/virt/kvm/guest_mem.c b/virt/kvm/guest_mem.c index db644f7fa48b..c81d2bb9ae93 100644 --- a/virt/kvm/guest_mem.c +++ b/virt/kvm/guest_mem.c @@ -479,7 +479,7 @@ int kvm_gmem_bind(struct kvm *kvm, struct kvm_memory_slot *slot, file = fget(fd); if (!file) - return -EINVAL; + return -EBADF; if (file->f_op != &kvm_gmem_fops) goto err;