From patchwork Sun Aug 2 23:58:18 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Goldish X-Patchwork-Id: 38814 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n72Nt15k009582 for ; Sun, 2 Aug 2009 23:55:01 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754003AbZHBXy5 (ORCPT ); Sun, 2 Aug 2009 19:54:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753978AbZHBXy5 (ORCPT ); Sun, 2 Aug 2009 19:54:57 -0400 Received: from mx2.redhat.com ([66.187.237.31]:37222 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753945AbZHBXyz (ORCPT ); Sun, 2 Aug 2009 19:54:55 -0400 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n72Ns5gR016645; Sun, 2 Aug 2009 19:54:15 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n72Nrsnv022173; Sun, 2 Aug 2009 19:53:54 -0400 Received: from localhost.localdomain (dhcp-1-188.tlv.redhat.com [10.35.1.188]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n72Nre6P017975; Sun, 2 Aug 2009 19:53:53 -0400 From: Michael Goldish To: autotest@test.kernel.org, kvm@vger.kernel.org Cc: Michael Goldish Subject: [KVM-AUTOTEST PATCH 09/12] KVM test: dynamically detect and cache MAC-IP pairs using tcpdump Date: Mon, 3 Aug 2009 02:58:18 +0300 Message-Id: In-Reply-To: References: <1249257501-19337-1-git-send-email-mgoldish@redhat.com> <7845d2fd228ec0232af10e48dbb29e1076a265d6.1249257056.git.mgoldish@redhat.com> <9ec0626f3ca8c20d08cfd2448dbf249632ed969a.1249257056.git.mgoldish@redhat.com> <30ddf2ae0b04eb29d55dcece97fd956b75563045.1249257056.git.mgoldish@redhat.com> <3e87b54663c4483d10912231945fc37741087b8f.1249257056.git.mgoldish@redhat.com> <9d4ca96f1445db6df176825a494d6504a3bddeba.1249257056.git.mgoldish@redhat.com> <8a2d08b846334a5eb097c2f32348d0c04a6789fb.1249257056.git.mgoldish@redhat.com> <603d8e9011205d1586b36dffead3823a2a61a745.1249257056.git.mgoldish@redhat.com> In-Reply-To: <7845d2fd228ec0232af10e48dbb29e1076a265d6.1249257056.git.mgoldish@redhat.com> References: <7845d2fd228ec0232af10e48dbb29e1076a265d6.1249257056.git.mgoldish@redhat.com> X-Scanned-By: MIMEDefang 2.58 on 172.16.27.26 Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Run tcpdump in the background at all times and listen for DHCP communication. Whenever a DHCP server assigns an IP address to a MAC address, cache it for future reference. Signed-off-by: Michael Goldish --- client/tests/kvm/kvm_preprocessing.py | 41 +++++++++++++++++++++++++++++++++ 1 files changed, 41 insertions(+), 0 deletions(-) diff --git a/client/tests/kvm/kvm_preprocessing.py b/client/tests/kvm/kvm_preprocessing.py index 4d77630..04bdb59 100644 --- a/client/tests/kvm/kvm_preprocessing.py +++ b/client/tests/kvm/kvm_preprocessing.py @@ -196,6 +196,26 @@ def preprocess(test, params, env): @param params: A dict containing all VM and image parameters. @param env: The environment (a dict-like object). """ + # Start tcpdump if it isn't already running + if not env.has_key("address_cache"): + env["address_cache"] = {} + if env.has_key("tcpdump") and not env["tcpdump"].is_alive(): + env["tcpdump"].close() + del env["tcpdump"] + if not env.has_key("tcpdump"): + command = "/usr/sbin/tcpdump -npvi any 'dst port 68'" + logging.debug("Starting tcpdump (%s)...", command) + env["tcpdump"] = kvm_subprocess.kvm_tail( + command=command, + output_func=_update_address_cache, + output_params=(env["address_cache"],)) + if kvm_utils.wait_for(lambda: not env["tcpdump"].is_alive(), + 0.1, 0.1, 1.0): + logging.warn("Could not start tcpdump") + logging.warn("Status: %s" % env["tcpdump"].get_status()) + logging.warn("Output:" + kvm_utils.format_str_for_message( + env["tcpdump"].get_output())) + # Destroy and remove VMs that are no longer needed in the environment requested_vms = kvm_utils.get_sub_dict_names(params, "vms") for key in env.keys(): @@ -280,6 +300,12 @@ def postprocess(test, params, env): int(params.get("post_command_timeout", "600")), params.get("post_command_noncritical") == "yes") + # Terminate tcpdump if no VMs are alive + living_vms = [vm for vm in kvm_utils.env_get_all_vms(env) if vm.is_alive()] + if not living_vms and env.has_key("tcpdump"): + env["tcpdump"].close() + del env["tcpdump"] + def postprocess_on_error(test, params, env): """ @@ -290,3 +316,18 @@ def postprocess_on_error(test, params, env): @param env: The environment (a dict-like object). """ params.update(kvm_utils.get_sub_dict(params, "on_error")) + + +def _update_address_cache(address_cache, line): + if re.search("Your.IP", line, re.IGNORECASE): + matches = re.findall(r"\d*\.\d*\.\d*\.\d*", line) + if matches: + address_cache["last_seen"] = matches[0] + if re.search("Client.Ethernet.Address", line, re.IGNORECASE): + matches = re.findall(r"\w*:\w*:\w*:\w*:\w*:\w*", line) + if matches and address_cache.get("last_seen"): + mac_address = matches[0].lower() + logging.debug("(address cache) Adding cache entry: %s ---> %s", + mac_address, address_cache.get("last_seen")) + address_cache[mac_address] = address_cache.get("last_seen") + del address_cache["last_seen"]