From patchwork Wed Dec 2 10:36:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Garry X-Patchwork-Id: 11945637 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30927C64E7C for ; Wed, 2 Dec 2020 10:42:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D576B20872 for ; Wed, 2 Dec 2020 10:42:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388632AbgLBKlk (ORCPT ); Wed, 2 Dec 2020 05:41:40 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:9094 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388618AbgLBKlj (ORCPT ); Wed, 2 Dec 2020 05:41:39 -0500 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CmFqC10fMzLx7h; Wed, 2 Dec 2020 18:40:23 +0800 (CST) Received: from localhost.localdomain (10.69.192.58) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.487.0; Wed, 2 Dec 2020 18:40:47 +0800 From: John Garry To: , , , , , , CC: , , , , , "John Garry" Subject: [PATCH v5 0/5] Support managed interrupts for platform devices Date: Wed, 2 Dec 2020 18:36:52 +0800 Message-ID: <1606905417-183214-1-git-send-email-john.garry@huawei.com> X-Mailer: git-send-email 2.8.1 MIME-Version: 1.0 X-Originating-IP: [10.69.192.58] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org So far, managed interrupts are only used for PCI MSIs. This series adds platform device support for managed interrupts. Initially this topic was discussed at [0]. The method to enable managed interrupts is to allocate a group of IRQs for the device, and then switch the interrupts to managed - this is done through new function irq_update_affinity_desc(). Function devm_platform_get_irqs_affinity() is added as a helper to manage this work, such that we don't need to export irq_update_affinity_desc() or irq_create_affinity_masks(). In the devm_platform_get_irqs_affinity() release call we are required to "put" or unmap the irqs which have been setup. The reason for this is that per-irq mapping (and irq_desc) needs to be recreated anew for re-probing the LLDD, such that we don't attempt to reconfigure the managed or any other flag for an irq_desc. For now, the HiSilicon SAS v2 hw driver is switched over. This is used in the D05 dev board. Performance gain observed for 6x SAS SSDs is ~357K -> 420K IOPs for fio read. This series is tested based on Marc's "MSI: Track device proxying when allocating MSIs" series, [1]. [0] https://lore.kernel.org/lkml/84a9411b-4ae3-1928-3d35-1666f2687ec8@huawei.com/ [1] https://lore.kernel.org/lkml/20201129135208.680293-1-maz@kernel.org/ Changes since v4: - Add Rafael's tags (thanks) - Expand commit message and code comment for genirq change Changes since v3: - Fix genirq change to re-activate interrupt if we have deactivated it - Remove standalone platform_put_irq(), and combine code into devm_platform_get_irqs_affinity_release() - Add new inline function in ioport.h rather than making acpi_dev_irqresource_disabled() public Changes since v2: - Update genirq change as follows: - Handle when the irq is started, active, or already managed - Reject update when CONFIG_GENERIC_IRQ_RESERVATION_MODE is set - Revamp platform.c API as follows: - Make it devm type - Add platform_put_irq() and associated change in ACPI code to allow irq resource to be reset - Unmap irqs for driver removal - Change API to accept min and max vectors John Garry (5): genirq/affinity: Add irq_update_affinity_desc() resource: Add irqresource_disabled() ACPI: Drop acpi_dev_irqresource_disabled() Driver core: platform: Add devm_platform_get_irqs_affinity() scsi: hisi_sas: Expose HW queues for v2 hw drivers/acpi/resource.c | 17 +--- drivers/base/platform.c | 121 +++++++++++++++++++++++++ drivers/scsi/hisi_sas/hisi_sas.h | 4 + drivers/scsi/hisi_sas/hisi_sas_main.c | 11 +++ drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 66 +++++++++++--- include/linux/interrupt.h | 8 ++ include/linux/ioport.h | 7 ++ include/linux/platform_device.h | 6 ++ kernel/irq/manage.c | 70 ++++++++++++++ 9 files changed, 285 insertions(+), 25 deletions(-)