From patchwork Sun Sep 23 13:58:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 10611719 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1283F14DA for ; Sun, 23 Sep 2018 13:58:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0015D29F08 for ; Sun, 23 Sep 2018 13:58:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E682229F20; Sun, 23 Sep 2018 13:58:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 87CD929F08 for ; Sun, 23 Sep 2018 13:58:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726215AbeIWTzv (ORCPT ); Sun, 23 Sep 2018 15:55:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57756 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726168AbeIWTzv (ORCPT ); Sun, 23 Sep 2018 15:55:51 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 93FC6C04F4DC; Sun, 23 Sep 2018 13:58:16 +0000 (UTC) Received: from shalem.localdomain.com (ovpn-116-53.ams2.redhat.com [10.36.116.53]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6775017F3E; Sun, 23 Sep 2018 13:58:13 +0000 (UTC) From: Hans de Goede To: "Rafael J . Wysocki" , Len Brown , Andy Shevchenko , Mika Westerberg , Jarkko Nikula , Wolfram Sang Cc: Hans de Goede , Adrian Hunter , linux@endlessm.com, linux-acpi@vger.kernel.org, linux-i2c@vger.kernel.org Subject: [PATCH v2 0/7] Resume BYT/CHT LPSS I2C controller before the iGPU Date: Sun, 23 Sep 2018 15:58:05 +0200 Message-Id: <20180923135812.29574-1-hdegoede@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Sun, 23 Sep 2018 13:58:16 +0000 (UTC) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi All, Here is v2 of my patch-series to make sure that on BYT/CHT systems the I2C controller connected to the PMIC gets resumed before the GPU. New in v2: -Dropped "ACPI / LPSS: Only add device links from consumer to supplier" patch this was based on wrongly reading the code and the code it removed is fine -Added "ACPI / LPSS: Add a device link from the GPU to the BYT I2C5 controller" it turns out we need to order things correctly on BYT too, otherwise things also fail, but in a much nastier way then on CHT, see the commit msg of the new patch Below is the original coverletter of v1 of the patch-set: On some Cherry Trail systems the GPU ACPI fwnode has power-resources which point to the PMIC, which is connected over the LPSS I2C7 controller. Currently the I2C controller resumes after the GPU is resumed leading to the following errors: i2c_designware 808622C1:06: controller timed out ACPI Error: AE_ERROR, Returned by Handler for [UserDefinedRegion] ACPI Error: Method parse/execution failed \_SB.P18W._ON, AE_ERROR video LNXVIDEO:00: Failed to change power state to D0 This series fixes this. This actually requires 3 separate fixes each of which is necessary and the error only goes away once all 3 are in place: 1) Patches 1-3 rework the acpi_lpss.c device-link code added by commit e6ce0ce34f65 ("ACPI / LPSS: Add device link for CHT SD card dependency on I2") so that the code can be used to add a device link between an ACPI LPSS device and a PCI device (the GPU). Patch 4 an 5 then actually add the device-links. Note that the other 2 fixes may give the impression that this fix is not necessary, that is not the case we most both make sure that the resume happens during the right resume phase *and* that within that phase it is done before the GPU resume 2) The GPU is a PCI device and PCI devices are brought up (moved from D3 to D0) in the noirq phase already. Normally ACPI LPSS device gets resumed in the resume_early phase. The ordering from 1) only orders things within the same phase. To make sure the I2C controller is ready before the GPU resumes we must resume LPSS I2C controllers (on BYT and CHT) from the noirq phase. This is done in patch 6. 3) Now we get a timeout waiting for the IRQ in the i2c-designware driver since IRQs are disabled in the noirq resume phase. Patch 7 marks the IRQ for BYT/CHT ACPI-LPSS i2c-designware controllers with IRQF_NO_SUSPEND. These patches are posted a single series since together they fix a single problem. But both the acpi_lpss and i2c-designware code have seen some churn in -next and not having patch 7 in place results in the error staying the same, so patches 1-6 can be merged indepedently without causing any regresssions (and patch 7 without 1-6 is not an issue either). Therefor I suggest that the acpi_lpss.c and the i2c-designware changes get merged through separate trees. Regards, Hans Reviewed-by: Andy Shevchenko