[v3,0/4] Remove one more platform_device_add_properties() call

Message

Heikki Krogerus Jan. 15, 2021, 9:49 a.m. UTC

Hi,

I'm now clearing the dev_fwnode(dev)->secondary pointer in
device_remove_software_node() as requested by Daniel and Andy. Thanks
guys, it's much better now. I also took the liberty of including one
more PCI ID patch where I add PCI ID for the Alder Lake-P variant. I
hope that is OK.

Andy, I dropped your Tested-by tag because of the change I made to the
first patch. If you have time to retest these, I would much appreciate.


v2 cover letter:

Hi Felipe, Rafael,

This is the second version of this series. There are no real changes,
but I added the Tiger Lake ID patch to this series in hope that it
will make your life a bit easier, assuming that Rafael will still pick
these.


The original over letter:

I originally introduced these as part of my series where I was
proposing PM ops for software nodes [1], but since that still needs
work, I'm sending these two separately.

So basically I'm only modifying dwc3-pci.c so it registers a software
node directly at this point. That will remove one more user of
platform_device_add_properties().

[1] https://lore.kernel.org/lkml/[e-mail]/

thanks,

Heikki Krogerus (4):
  software node: Introduce device_add_software_node()
  usb: dwc3: pci: Register a software node for the dwc3 platform device
  usb: dwc3: pci: ID for Tiger Lake CPU
  usb: dwc3: pci: add support for the Intel Alder Lake-P

 drivers/base/swnode.c       | 71 ++++++++++++++++++++++++++++++++-----
 drivers/usb/dwc3/dwc3-pci.c | 69 ++++++++++++++++++++++-------------
 include/linux/property.h    |  3 ++
 3 files changed, 110 insertions(+), 33 deletions(-)

Comments

Andy Shevchenko Jan. 16, 2021, 8:23 p.m. UTC | #1

On Fri, Jan 15, 2021 at 11:52 AM Heikki Krogerus
<[e-mail]> wrote:
>
> Hi,
>
> I'm now clearing the dev_fwnode(dev)->secondary pointer in
> device_remove_software_node() as requested by Daniel and Andy. Thanks
> guys, it's much better now. I also took the liberty of including one
> more PCI ID patch where I add PCI ID for the Alder Lake-P variant. I
> hope that is OK.
>
> Andy, I dropped your Tested-by tag because of the change I made to the
> first patch. If you have time to retest these, I would much appreciate.

Since Greg already grabbed a v3 I will test it when it appears in linux-next.

Daniel Scally Jan. 16, 2021, 9:29 p.m. UTC | #2

On 16/01/2021 20:23, Andy Shevchenko wrote:
> On Fri, Jan 15, 2021 at 11:52 AM Heikki Krogerus
> <[e-mail]> wrote:
>> Hi,
>>
>> I'm now clearing the dev_fwnode(dev)->secondary pointer in
>> device_remove_software_node() as requested by Daniel and Andy. Thanks
>> guys, it's much better now. I also took the liberty of including one
>> more PCI ID patch where I add PCI ID for the Alder Lake-P variant. I
>> hope that is OK.
>>
>> Andy, I dropped your Tested-by tag because of the change I made to the
>> first patch. If you have time to retest these, I would much appreciate.
> Since Greg already grabbed a v3 I will test it when it appears in linux-next.
>
It seems the grabbed one is the v2 one though actually

Andy Shevchenko Jan. 17, 2021, 9:05 p.m. UTC | #3

On Sat, Jan 16, 2021 at 11:29 PM Daniel Scally <[e-mail]> wrote:
> On 16/01/2021 20:23, Andy Shevchenko wrote:
> > On Fri, Jan 15, 2021 at 11:52 AM Heikki Krogerus
> > <[e-mail]> wrote:
> >> Hi,
> >>
> >> I'm now clearing the dev_fwnode(dev)->secondary pointer in
> >> device_remove_software_node() as requested by Daniel and Andy. Thanks
> >> guys, it's much better now. I also took the liberty of including one
> >> more PCI ID patch where I add PCI ID for the Alder Lake-P variant. I
> >> hope that is OK.
> >>
> >> Andy, I dropped your Tested-by tag because of the change I made to the
> >> first patch. If you have time to retest these, I would much appreciate.
> > Since Greg already grabbed a v3 I will test it when it appears in linux-next.
> >
> It seems the grabbed one is the v2 one though actually

In his last message he wrote that he noticed the v3 *as I understand that*.
Greg, is it right? I mean you took v3 eventually?

Daniel Scally Jan. 17, 2021, 9:15 p.m. UTC | #4

On 17/01/2021 21:05, Andy Shevchenko wrote:
> On Sat, Jan 16, 2021 at 11:29 PM Daniel Scally <[e-mail]> wrote:
>> On 16/01/2021 20:23, Andy Shevchenko wrote:
>>> On Fri, Jan 15, 2021 at 11:52 AM Heikki Krogerus
>>> <[e-mail]> wrote:
>>>> Hi,
>>>>
>>>> I'm now clearing the dev_fwnode(dev)->secondary pointer in
>>>> device_remove_software_node() as requested by Daniel and Andy. Thanks
>>>> guys, it's much better now. I also took the liberty of including one
>>>> more PCI ID patch where I add PCI ID for the Alder Lake-P variant. I
>>>> hope that is OK.
>>>>
>>>> Andy, I dropped your Tested-by tag because of the change I made to the
>>>> first patch. If you have time to retest these, I would much appreciate.
>>> Since Greg already grabbed a v3 I will test it when it appears in linux-next.
>>>
>> It seems the grabbed one is the v2 one though actually
> In his last message he wrote that he noticed the v3 *as I understand that*.
> Greg, is it right? I mean you took v3 eventually?
>
You're right:

https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-testing&id=e68d0119e3284334de5650a1ac42ef4e179f895e

My bad; I went off the automated message but didn't check the tree.