mbox series

[v1,00/10] mfd, x86: remove msic driver and leftovers

Message ID 20210125193948.56760-1-andriy.shevchenko@linux.intel.com (mailing list archive)
Headers show
Series mfd, x86: remove msic driver and leftovers | expand

Message

Andy Shevchenko Jan. 25, 2021, 7:39 p.m. UTC
This is a second part of the Intel MID outdated platforms removal.
First part is available as immutable branch [1]. The series has functional
and build dependencies, so the mentioned branch should be used as a base
for these changes.

Note, that some of the drivers, that arch/x86 covers, seems never appeared
in the upstream (like msic_ocd).

There few ways are possible to proceed with this:
- extend existing immutable branch
- create another one based on MFD
- merge everything thru tip tree

I'm also all ears for alternatives.

The entire branch with all patches is available here [2].

Rafael, can you please help reviewing arch/x86 related code?

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=intel-mid-removal
[2]: https://gitlab.com/andy-shev/next/-/tree/topic/mid-removal-next

Andy Shevchenko (10):
  x86/platform/intel-mid: Remove unused leftovers (msic_audio)
  x86/platform/intel-mid: Remove unused leftovers (msic_ocd)
  x86/platform/intel-mid: Remove unused leftovers (msic_battery)
  x86/platform/intel-mid: Remove unused leftovers (msic_gpio)
  x86/platform/intel-mid: Remove unused leftovers (msic_power_btn)
  x86/platform/intel-mid: Remove unused leftovers (msic_thermal)
  x86/platform/intel-mid: Remove unused leftovers (msic)
  x86/platform/intel-mid: Remove unused leftovers (vRTC)
  x86/apb_timer: Remove driver for deprecated platform
  mfd: intel_msic: Remove driver for deprecated platform

 .../admin-guide/kernel-parameters.txt         |   6 -
 MAINTAINERS                                   |   2 -
 arch/x86/Kconfig                              |  12 -
 arch/x86/include/asm/apb_timer.h              |  40 --
 arch/x86/include/asm/fixmap.h                 |   3 -
 arch/x86/include/asm/intel-mid.h              |  28 --
 arch/x86/include/asm/intel_mid_vrtc.h         |  10 -
 arch/x86/include/asm/intel_scu_ipc_legacy.h   |  17 -
 arch/x86/kernel/Makefile                      |   1 -
 arch/x86/kernel/apb_timer.c                   | 347 --------------
 arch/x86/platform/intel-mid/Makefile          |   2 +-
 .../platform/intel-mid/device_libs/Makefile   |   9 -
 .../device_libs/platform_mrfld_power_btn.c    |  78 ---
 .../intel-mid/device_libs/platform_msic.c     |  83 ----
 .../intel-mid/device_libs/platform_msic.h     |  15 -
 .../device_libs/platform_msic_audio.c         |  42 --
 .../device_libs/platform_msic_battery.c       |  32 --
 .../device_libs/platform_msic_gpio.c          |  43 --
 .../intel-mid/device_libs/platform_msic_ocd.c |  44 --
 .../device_libs/platform_msic_power_btn.c     |  31 --
 .../device_libs/platform_msic_thermal.c       |  32 --
 arch/x86/platform/intel-mid/intel-mid.c       |  79 +--
 arch/x86/platform/intel-mid/intel_mid_vrtc.c  | 173 -------
 arch/x86/platform/intel-mid/sfi.c             | 124 -----
 drivers/mfd/Kconfig                           |   9 -
 drivers/mfd/Makefile                          |   1 -
 drivers/mfd/intel_msic.c                      | 425 ----------------
 include/linux/mfd/intel_msic.h                | 453 ------------------
 28 files changed, 4 insertions(+), 2137 deletions(-)
 delete mode 100644 arch/x86/include/asm/apb_timer.h
 delete mode 100644 arch/x86/include/asm/intel_mid_vrtc.h
 delete mode 100644 arch/x86/kernel/apb_timer.c
 delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_mrfld_power_btn.c
 delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_msic.c
 delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_msic.h
 delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_msic_audio.c
 delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_msic_battery.c
 delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_msic_gpio.c
 delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_msic_ocd.c
 delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_msic_power_btn.c
 delete mode 100644 arch/x86/platform/intel-mid/device_libs/platform_msic_thermal.c
 delete mode 100644 arch/x86/platform/intel-mid/intel_mid_vrtc.c
 delete mode 100644 drivers/mfd/intel_msic.c
 delete mode 100644 include/linux/mfd/intel_msic.h

Comments

Lee Jones Jan. 26, 2021, 8:21 a.m. UTC | #1
On Mon, 25 Jan 2021, Andy Shevchenko wrote:

> This is a second part of the Intel MID outdated platforms removal.
> First part is available as immutable branch [1]. The series has functional
> and build dependencies, so the mentioned branch should be used as a base
> for these changes.
> 
> Note, that some of the drivers, that arch/x86 covers, seems never appeared
> in the upstream (like msic_ocd).

What platforms stop working after this removal?

Are you sure no-one is using them?

I wouldn't be keen on breaking Janet's PC that she's been using daily
and keeping up-to-date since the 90's.
Andy Shevchenko Jan. 26, 2021, 10:39 a.m. UTC | #2
On Tue, Jan 26, 2021 at 08:21:01AM +0000, Lee Jones wrote:
> On Mon, 25 Jan 2021, Andy Shevchenko wrote:
> 
> > This is a second part of the Intel MID outdated platforms removal.
> > First part is available as immutable branch [1]. The series has functional
> > and build dependencies, so the mentioned branch should be used as a base
> > for these changes.
> > 
> > Note, that some of the drivers, that arch/x86 covers, seems never appeared
> > in the upstream (like msic_ocd).
> 
> What platforms stop working after this removal?

Intel Moorstown, Medfield, Clovertrail.

> Are you sure no-one is using them?

Definitely.

> I wouldn't be keen on breaking Janet's PC that she's been using daily
> and keeping up-to-date since the 90's.

They never were in PCs.

All of them were supported by Android and Janet won't update her phone or even
Android tablet for sure they never ever run any kind of Linux than Android.
Andy Shevchenko Feb. 1, 2021, 6:43 p.m. UTC | #3
On Tue, Jan 26, 2021 at 12:39:59PM +0200, Andy Shevchenko wrote:
> On Tue, Jan 26, 2021 at 08:21:01AM +0000, Lee Jones wrote:
> > On Mon, 25 Jan 2021, Andy Shevchenko wrote:
> > 
> > > This is a second part of the Intel MID outdated platforms removal.
> > > First part is available as immutable branch [1]. The series has functional
> > > and build dependencies, so the mentioned branch should be used as a base
> > > for these changes.
> > > 
> > > Note, that some of the drivers, that arch/x86 covers, seems never appeared
> > > in the upstream (like msic_ocd).
> > 
> > What platforms stop working after this removal?
> 
> Intel Moorstown, Medfield, Clovertrail.
> 
> > Are you sure no-one is using them?
> 
> Definitely.
> 
> > I wouldn't be keen on breaking Janet's PC that she's been using daily
> > and keeping up-to-date since the 90's.
> 
> They never were in PCs.
> 
> All of them were supported by Android and Janet won't update her phone or even
> Android tablet for sure they never ever run any kind of Linux than Android.

So, I hope you are satisfied and we may proceed with removal.
Rafael J. Wysocki Feb. 1, 2021, 6:49 p.m. UTC | #4
On Mon, Feb 1, 2021 at 7:45 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Tue, Jan 26, 2021 at 12:39:59PM +0200, Andy Shevchenko wrote:
> > On Tue, Jan 26, 2021 at 08:21:01AM +0000, Lee Jones wrote:
> > > On Mon, 25 Jan 2021, Andy Shevchenko wrote:
> > >
> > > > This is a second part of the Intel MID outdated platforms removal.
> > > > First part is available as immutable branch [1]. The series has functional
> > > > and build dependencies, so the mentioned branch should be used as a base
> > > > for these changes.
> > > >
> > > > Note, that some of the drivers, that arch/x86 covers, seems never appeared
> > > > in the upstream (like msic_ocd).
> > >
> > > What platforms stop working after this removal?
> >
> > Intel Moorstown, Medfield, Clovertrail.
> >
> > > Are you sure no-one is using them?
> >
> > Definitely.
> >
> > > I wouldn't be keen on breaking Janet's PC that she's been using daily
> > > and keeping up-to-date since the 90's.
> >
> > They never were in PCs.
> >
> > All of them were supported by Android and Janet won't update her phone or even
> > Android tablet for sure they never ever run any kind of Linux than Android.
>
> So, I hope you are satisfied and we may proceed with removal.

Speaking of which, the patches here are requisite for SFI support
removal, so I'd like to route them through the ACPI tree if that's
fine by all of the interested parties.

Thanks!
Andy Shevchenko Feb. 1, 2021, 8:57 p.m. UTC | #5
On Mon, Feb 1, 2021 at 8:52 PM Rafael J. Wysocki <rafael@kernel.org> wrote:
> On Mon, Feb 1, 2021 at 7:45 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:

...

> Speaking of which, the patches here are requisite for SFI support
> removal, so I'd like to route them through the ACPI tree if that's
> fine by all of the interested parties.

Fine with me!
Lee Jones Feb. 2, 2021, 8:15 a.m. UTC | #6
On Mon, 01 Feb 2021, Rafael J. Wysocki wrote:

> On Mon, Feb 1, 2021 at 7:45 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> >
> > On Tue, Jan 26, 2021 at 12:39:59PM +0200, Andy Shevchenko wrote:
> > > On Tue, Jan 26, 2021 at 08:21:01AM +0000, Lee Jones wrote:
> > > > On Mon, 25 Jan 2021, Andy Shevchenko wrote:
> > > >
> > > > > This is a second part of the Intel MID outdated platforms removal.
> > > > > First part is available as immutable branch [1]. The series has functional
> > > > > and build dependencies, so the mentioned branch should be used as a base
> > > > > for these changes.
> > > > >
> > > > > Note, that some of the drivers, that arch/x86 covers, seems never appeared
> > > > > in the upstream (like msic_ocd).
> > > >
> > > > What platforms stop working after this removal?
> > >
> > > Intel Moorstown, Medfield, Clovertrail.
> > >
> > > > Are you sure no-one is using them?
> > >
> > > Definitely.
> > >
> > > > I wouldn't be keen on breaking Janet's PC that she's been using daily
> > > > and keeping up-to-date since the 90's.
> > >
> > > They never were in PCs.
> > >
> > > All of them were supported by Android and Janet won't update her phone or even
> > > Android tablet for sure they never ever run any kind of Linux than Android.
> >
> > So, I hope you are satisfied and we may proceed with removal.
> 
> Speaking of which, the patches here are requisite for SFI support
> removal, so I'd like to route them through the ACPI tree if that's
> fine by all of the interested parties.

Shouldn't cause too much disruption.

Ack provided.
Rafael J. Wysocki Feb. 3, 2021, 7:05 p.m. UTC | #7
On Tue, Feb 2, 2021 at 9:15 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Mon, 01 Feb 2021, Rafael J. Wysocki wrote:
>
> > On Mon, Feb 1, 2021 at 7:45 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > On Tue, Jan 26, 2021 at 12:39:59PM +0200, Andy Shevchenko wrote:
> > > > On Tue, Jan 26, 2021 at 08:21:01AM +0000, Lee Jones wrote:
> > > > > On Mon, 25 Jan 2021, Andy Shevchenko wrote:
> > > > >
> > > > > > This is a second part of the Intel MID outdated platforms removal.
> > > > > > First part is available as immutable branch [1]. The series has functional
> > > > > > and build dependencies, so the mentioned branch should be used as a base
> > > > > > for these changes.
> > > > > >
> > > > > > Note, that some of the drivers, that arch/x86 covers, seems never appeared
> > > > > > in the upstream (like msic_ocd).
> > > > >
> > > > > What platforms stop working after this removal?
> > > >
> > > > Intel Moorstown, Medfield, Clovertrail.
> > > >
> > > > > Are you sure no-one is using them?
> > > >
> > > > Definitely.
> > > >
> > > > > I wouldn't be keen on breaking Janet's PC that she's been using daily
> > > > > and keeping up-to-date since the 90's.
> > > >
> > > > They never were in PCs.
> > > >
> > > > All of them were supported by Android and Janet won't update her phone or even
> > > > Android tablet for sure they never ever run any kind of Linux than Android.
> > >
> > > So, I hope you are satisfied and we may proceed with removal.
> >
> > Speaking of which, the patches here are requisite for SFI support
> > removal, so I'd like to route them through the ACPI tree if that's
> > fine by all of the interested parties.
>
> Shouldn't cause too much disruption.
>
> Ack provided.

Thanks!

This series has been applied as 5.12 material and will show up in
linux-next on Friday if all goes well.

I can export an immutable branch with these commits if need be, in
which case please let me know.

Andy, please proceed with the SFI support removal submission.
Andy Shevchenko Feb. 3, 2021, 7:28 p.m. UTC | #8
On Wed, Feb 03, 2021 at 08:05:55PM +0100, Rafael J. Wysocki wrote:
> On Tue, Feb 2, 2021 at 9:15 AM Lee Jones <lee.jones@linaro.org> wrote:

...

> This series has been applied as 5.12 material and will show up in
> linux-next on Friday if all goes well.
> 
> I can export an immutable branch with these commits if need be, in
> which case please let me know.

I guess it makes sense just in case of a formal pinning, but if SFI will go
through your tree, the only potential consumer will be that tree.

> Andy, please proceed with the SFI support removal submission.

Will do, thanks all!