| Message ID | 20210816115953.72533-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | gpio: mlxbf2: Introduce proper interrupt handling | expand |
On Mon, Aug 16, 2021 at 3:01 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > This is just a WIP / TODO series based on the discussion [1]. > I hope nVidia will finish it and fix the initial problem sooner than later. > > Bart, Linus, First 4 patches may be directly applied to the tree (they are > at least compile-tested, but I believe they won't change any functionality. > > Patch 5 is some stubs that should have been done in the driver. > Patch 6 is follow up removal of custom GPIO IRQ handling from > Mellanox GBE driver. Both of them are quite far from finishing, > but it's a start for nVidia to develop and test proper solution. > > In any case, I will probably sent end this week the ACPI IRQ abuse > part from the GBE driver (I won't touch OF path). > > ARs for nVidia: > 0) review this series; > 1) properly develop GPIO driver; > 2) replace custom code with correct one; > 3) send the work for review to GPIO and ACPI maintainers (basically list > of this series). > > On my side I will help you if you have any questions regarding to GPIO > and ACPI. Missed link [1]: https://x-lore.kernel.org/linux-acpi/YRUskkALrPLa2cSf@smile.fi.intel.com/T/#u > Andy Shevchenko (6): > gpio: mlxbf2: Convert to device PM ops > gpio: mlxbf2: Drop wrong use of ACPI_PTR() > gpio: mlxbf2: Use devm_platform_ioremap_resource() > gpio: mlxbf2: Use DEFINE_RES_MEM_NAMED() helper macro > TODO: gpio: mlxbf2: Introduce IRQ support > TODO: net: mellanox: mlxbf_gige: Replace non-standard interrupt > handling > > drivers/gpio/gpio-mlxbf2.c | 151 ++++++++++--- > .../mellanox/mlxbf_gige/mlxbf_gige_gpio.c | 212 ------------------ > 2 files changed, 120 insertions(+), 243 deletions(-) > delete mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_gpio.c > > -- > 2.30.2 >
On Mon, Aug 16, 2021 at 2:00 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > This is just a WIP / TODO series based on the discussion [1]. > I hope nVidia will finish it and fix the initial problem sooner than later. > > Bart, Linus, First 4 patches may be directly applied to the tree (they are > at least compile-tested, but I believe they won't change any functionality. > > Patch 5 is some stubs that should have been done in the driver. > Patch 6 is follow up removal of custom GPIO IRQ handling from > Mellanox GBE driver. Both of them are quite far from finishing, > but it's a start for nVidia to develop and test proper solution. > > In any case, I will probably sent end this week the ACPI IRQ abuse > part from the GBE driver (I won't touch OF path). > > ARs for nVidia: > 0) review this series; > 1) properly develop GPIO driver; > 2) replace custom code with correct one; > 3) send the work for review to GPIO and ACPI maintainers (basically list > of this series). > > On my side I will help you if you have any questions regarding to GPIO > and ACPI. > > Andy Shevchenko (6): > gpio: mlxbf2: Convert to device PM ops > gpio: mlxbf2: Drop wrong use of ACPI_PTR() > gpio: mlxbf2: Use devm_platform_ioremap_resource() > gpio: mlxbf2: Use DEFINE_RES_MEM_NAMED() helper macro > TODO: gpio: mlxbf2: Introduce IRQ support > TODO: net: mellanox: mlxbf_gige: Replace non-standard interrupt > handling > > drivers/gpio/gpio-mlxbf2.c | 151 ++++++++++--- > .../mellanox/mlxbf_gige/mlxbf_gige_gpio.c | 212 ------------------ > 2 files changed, 120 insertions(+), 243 deletions(-) > delete mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_gpio.c > > -- > 2.30.2 > Applied first four patches. Bart
This is just a WIP / TODO series based on the discussion [1]. I hope nVidia will finish it and fix the initial problem sooner than later. Bart, Linus, First 4 patches may be directly applied to the tree (they are at least compile-tested, but I believe they won't change any functionality. Patch 5 is some stubs that should have been done in the driver. Patch 6 is follow up removal of custom GPIO IRQ handling from Mellanox GBE driver. Both of them are quite far from finishing, but it's a start for nVidia to develop and test proper solution. In any case, I will probably sent end this week the ACPI IRQ abuse part from the GBE driver (I won't touch OF path). ARs for nVidia: 0) review this series; 1) properly develop GPIO driver; 2) replace custom code with correct one; 3) send the work for review to GPIO and ACPI maintainers (basically list of this series). On my side I will help you if you have any questions regarding to GPIO and ACPI. Andy Shevchenko (6): gpio: mlxbf2: Convert to device PM ops gpio: mlxbf2: Drop wrong use of ACPI_PTR() gpio: mlxbf2: Use devm_platform_ioremap_resource() gpio: mlxbf2: Use DEFINE_RES_MEM_NAMED() helper macro TODO: gpio: mlxbf2: Introduce IRQ support TODO: net: mellanox: mlxbf_gige: Replace non-standard interrupt handling drivers/gpio/gpio-mlxbf2.c | 151 ++++++++++--- .../mellanox/mlxbf_gige/mlxbf_gige_gpio.c | 212 ------------------ 2 files changed, 120 insertions(+), 243 deletions(-) delete mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_gpio.c