From patchwork Mon Sep 20 21:22:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Asmaa Mnebhi X-Patchwork-Id: 12506359 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 073CAC433F5 for ; Mon, 20 Sep 2021 21:24:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D80AA611AF for ; Mon, 20 Sep 2021 21:24:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235508AbhITV0H (ORCPT ); Mon, 20 Sep 2021 17:26:07 -0400 Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:36806 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235133AbhITVYH (ORCPT ); Mon, 20 Sep 2021 17:24:07 -0400 Received: from Internal Mail-Server by MTLPINE1 (envelope-from asmaa@mellanox.com) with SMTP; 21 Sep 2021 00:22:35 +0300 Received: from farm-0002.mtbu.labs.mlnx (farm-0002.mtbu.labs.mlnx [10.15.2.32]) by mtbu-labmailer.labs.mlnx (8.14.4/8.14.4) with ESMTP id 18KLMXoW030011; Mon, 20 Sep 2021 17:22:33 -0400 Received: (from asmaa@localhost) by farm-0002.mtbu.labs.mlnx (8.14.7/8.13.8/Submit) id 18KLMUk5019405; Mon, 20 Sep 2021 17:22:30 -0400 From: Asmaa Mnebhi To: andy.shevchenko@gmail.com, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Cc: Asmaa Mnebhi , andrew@lunn.ch, kuba@kernel.org, linus.walleij@linaro.org, bgolaszewski@baylibre.com, davem@davemloft.net, rjw@rjwysocki.net, davthompson@nvidia.com Subject: [PATCH v2 0/2] gpio: mlxbf2: Introduce proper interrupt handling Date: Mon, 20 Sep 2021 17:22:25 -0400 Message-Id: <20210920212227.19358-1-asmaa@nvidia.com> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org This is a follow up on a discussion regarding proper handling of GPIO interrupts within the gpio-mlxbf2.c driver. Link to discussion: https://lore.kernel.org/netdev/20210816115953.72533-7-andriy.shevchenko@linux.intel.com/T/ Patch 1 adds support to a GPIO IRQ handler in gpio-mlxbf2.c. Patch 2 is a follow up removal of custom GPIO IRQ handling from the mlxbf_gige driver and replacing it with a simple IRQ request. The ACPI table for the mlxbf_gige driver is responsible for instantiating the PHY GPIO interrupt via GpioInt. Andy Shevchenko, could you please review this patch series. v2 vs. v1 patch: All changes were made in gpio-mlxbf2.c - removed unnecessary comments - removed irq_ack as it is not needed - removed irq_mask/irq_unmask as they are not invoked - remove IRQ_TYPE_LEVEL* from mlxbf2_gpio_irq_set_type since they are not supported Asmaa Mnebhi (2): gpio: mlxbf2: Introduce IRQ support net: mellanox: mlxbf_gige: Replace non-standard interrupt handling drivers/gpio/gpio-mlxbf2.c | 147 +++++++++++- .../net/ethernet/mellanox/mlxbf_gige/Makefile | 1 - .../ethernet/mellanox/mlxbf_gige/mlxbf_gige.h | 12 - .../mellanox/mlxbf_gige/mlxbf_gige_gpio.c | 212 ------------------ .../mellanox/mlxbf_gige/mlxbf_gige_main.c | 22 +- 5 files changed, 154 insertions(+), 240 deletions(-) delete mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_gpio.c