From patchwork Fri Oct 15 16:48:07 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Asmaa Mnebhi X-Patchwork-Id: 12562551 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68AB8C433FE for ; Fri, 15 Oct 2021 16:48:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4A9AB60F6F for ; Fri, 15 Oct 2021 16:48:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241520AbhJOQuj (ORCPT ); Fri, 15 Oct 2021 12:50:39 -0400 Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:33780 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S241399AbhJOQui (ORCPT ); Fri, 15 Oct 2021 12:50:38 -0400 Received: from Internal Mail-Server by MTLPINE1 (envelope-from asmaa@mellanox.com) with SMTP; 15 Oct 2021 19:48:27 +0300 Received: from farm-0002.mtbu.labs.mlnx (farm-0002.mtbu.labs.mlnx [10.15.2.32]) by mtbu-labmailer.labs.mlnx (8.14.4/8.14.4) with ESMTP id 19FGmP0b027764; Fri, 15 Oct 2021 12:48:26 -0400 Received: (from asmaa@localhost) by farm-0002.mtbu.labs.mlnx (8.14.7/8.13.8/Submit) id 19FGmH8G022057; Fri, 15 Oct 2021 12:48:17 -0400 From: Asmaa Mnebhi To: andy.shevchenko@gmail.com, linux-gpio@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org Cc: Asmaa Mnebhi , andrew@lunn.ch, kuba@kernel.org, linus.walleij@linaro.org, bgolaszewski@baylibre.com, davem@davemloft.net, rjw@rjwysocki.net, davthompson@nvidia.com Subject: [PATCH v5 0/2] gpio: mlxbf2: Introduce proper interrupt handling Date: Fri, 15 Oct 2021 12:48:07 -0400 Message-Id: <20211015164809.22009-1-asmaa@nvidia.com> X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org This is a follow up on a discussion regarding proper handling of GPIO interrupts within the gpio-mlxbf2.c driver. Link to discussion: https://lore.kernel.org/netdev/20210816115953.72533-7-andriy.shevchenko@linux.intel.com/T/ Patch 1 adds support to a GPIO IRQ handler in gpio-mlxbf2.c. Patch 2 is a follow up removal of custom GPIO IRQ handling from the mlxbf_gige driver and replacing it with a simple IRQ request. The ACPI table for the mlxbf_gige driver is responsible for instantiating the PHY GPIO interrupt via GpioInt. Andy Shevchenko, could you please review this patch series. David Miller, could you please ack the changes in the mlxbf_gige driver. v5 vs. v4 patch: - Remove a fix which check if bgpio_init has failed. This fix should in a separate patch targeting the stable branch. Asmaa Mnebhi (2): gpio: mlxbf2: Introduce IRQ support net: mellanox: mlxbf_gige: Replace non-standard interrupt handling drivers/gpio/gpio-mlxbf2.c | 142 +++++++++++- .../net/ethernet/mellanox/mlxbf_gige/Makefile | 1 - .../ethernet/mellanox/mlxbf_gige/mlxbf_gige.h | 12 - .../mellanox/mlxbf_gige/mlxbf_gige_gpio.c | 212 ------------------ .../mellanox/mlxbf_gige/mlxbf_gige_main.c | 22 +- 5 files changed, 149 insertions(+), 240 deletions(-) delete mode 100644 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_gpio.c Acked-by: David S. Miller