[0/1] ACPI: video: Fix acpi_video_handles_brightness_key_presses()

Message

Hans de Goede July 13, 2022, 9:11 p.m. UTC

Hi Rafael,

Commit 3a0cf7ab8df3 ("ACPI: video: Change how we determine if brightness
key-presses are handled") which fixes not sending any brightness
key-presses at all on some Panasonic models, because of
acpi_video_handles_brightness_key_presses() returning true while it
should not, is causing duplicate brightness key presses on some
(older) Dell models.

This patch fixes this. As mentioned in the commit message a down-side
of the fix is that the first brightness key-press on affected Dell models
might still get reported twice. The alternative would be DMI based quirks
and IMHO this generic fix is better.

Since I send the original commit to Linus through the pdx86 tree
as part of a panasonic-laptop driver fixes series, and since users
are reporting regressions because of the original fix now, I plan to
include this fix to the fix in my next fixes pull-req to Linus
this Friday.

If you have any objections against this fix please let me know
before Friday.

Regards,

Hans


Hans de Goede (1):
  ACPI: video: Fix acpi_video_handles_brightness_key_presses()

 drivers/acpi/acpi_video.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)