| Message ID | 20220829162953.5947-1-mario.limonciello@amd.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add some extra debugging mechanisms for s0i3 | expand |
Hi All, On 8/29/22 18:29, Mario Limonciello wrote: > Recently there have been reports of problems where the system consumes > too much power after certain interrupts occur that would notify the > kernel of some event but those events aren't marked for wakeup. > > These problems have been root caused to the timing of the kernel moving > the cores into ACPI C3 relative to other events from the previous wakeup > not being settled. Linux will more aggressively move the cores into C3 > for s2idle than Windows does for Modern Standby. > > To aide with debugging this class of problems in the future add a new > set of optional debugging infrastructure. > > Mario Limonciello (4): > ACPI: s2idle: Add a new ->check() callback for platform_s2idle_ops > platform/x86/amd: pmc: Add defines for STB events > platform/x86/amd: pmc: Always write to the STB > platform/x86/amd: pmc: Add an extra STB message for checking s2idle > entry Thank you for your patch-series, I've applied the series to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while. Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window. Regards, Hans > > drivers/acpi/sleep.h | 1 + > drivers/acpi/x86/s2idle.c | 14 ++++++++++++++ > drivers/platform/x86/amd/pmc.c | 32 ++++++++++++++++++++------------ > include/linux/acpi.h | 1 + > include/linux/suspend.h | 1 + > kernel/power/suspend.c | 3 +++ > 6 files changed, 40 insertions(+), 12 deletions(-) >
Recently there have been reports of problems where the system consumes too much power after certain interrupts occur that would notify the kernel of some event but those events aren't marked for wakeup. These problems have been root caused to the timing of the kernel moving the cores into ACPI C3 relative to other events from the previous wakeup not being settled. Linux will more aggressively move the cores into C3 for s2idle than Windows does for Modern Standby. To aide with debugging this class of problems in the future add a new set of optional debugging infrastructure. Mario Limonciello (4): ACPI: s2idle: Add a new ->check() callback for platform_s2idle_ops platform/x86/amd: pmc: Add defines for STB events platform/x86/amd: pmc: Always write to the STB platform/x86/amd: pmc: Add an extra STB message for checking s2idle entry drivers/acpi/sleep.h | 1 + drivers/acpi/x86/s2idle.c | 14 ++++++++++++++ drivers/platform/x86/amd/pmc.c | 32 ++++++++++++++++++++------------ include/linux/acpi.h | 1 + include/linux/suspend.h | 1 + kernel/power/suspend.c | 3 +++ 6 files changed, 40 insertions(+), 12 deletions(-)