| Message ID | 20230404110251.42449-1-hdegoede@redhat.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ACPI: video: Fix missing acpi_video# devices on some systems | expand |
Hi Hans, On Tue, Apr 4, 2023 at 1:03 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Hi Rafael, > > Here is my v2 of this series, changes in v2: > > - Add Mario's Reviewed-by to the series > - Fix typo in commit-message for 5/6 > - Drop no longer used video_detect_force_none() in 6/6 > > This patch series consists of 2 parts: > > 1. Fix missing acpi_video# devices on some systems, currently in kernels > >= 6.1.5 and >= 6.2.0 acpi_video# backlight class devices will only > get registered (by default) when a GPU driver asks for this by calling > acpi_video_register_backlight(). This is causing backlight control to > be missing on some systems. > > Patches 1-4 fix this and ideally these should be send to Linus for > an upcoming 6.3-rc# release. So I've applied these for now. Note that I generally hate to do things like this so late in the cycle, so this generally is an exception AFAIAC. > 2. Now that the dust has settled a bit on the backlight refactor we can > do some further cleanups. This is done in patches 5 + 6. Note that > patch 5 depends on patch 2. And I will queue up these 2 for 6.4 later. Thanks!
Hi Rafael, On 4/5/23 20:27, Rafael J. Wysocki wrote: > Hi Hans, > > On Tue, Apr 4, 2023 at 1:03 PM Hans de Goede <hdegoede@redhat.com> wrote: >> >> Hi Rafael, >> >> Here is my v2 of this series, changes in v2: >> >> - Add Mario's Reviewed-by to the series >> - Fix typo in commit-message for 5/6 >> - Drop no longer used video_detect_force_none() in 6/6 >> >> This patch series consists of 2 parts: >> >> 1. Fix missing acpi_video# devices on some systems, currently in kernels >> >= 6.1.5 and >= 6.2.0 acpi_video# backlight class devices will only >> get registered (by default) when a GPU driver asks for this by calling >> acpi_video_register_backlight(). This is causing backlight control to >> be missing on some systems. >> >> Patches 1-4 fix this and ideally these should be send to Linus for >> an upcoming 6.3-rc# release. > > So I've applied these for now. > > Note that I generally hate to do things like this so late in the > cycle, so this generally is an exception AFAIAC. Ok, thank you for taking them now. >> 2. Now that the dust has settled a bit on the backlight refactor we can >> do some further cleanups. This is done in patches 5 + 6. Note that >> patch 5 depends on patch 2. > > And I will queue up these 2 for 6.4 later. Regards, Hans
Hi Rafael, Here is my v2 of this series, changes in v2: - Add Mario's Reviewed-by to the series - Fix typo in commit-message for 5/6 - Drop no longer used video_detect_force_none() in 6/6 This patch series consists of 2 parts: 1. Fix missing acpi_video# devices on some systems, currently in kernels >= 6.1.5 and >= 6.2.0 acpi_video# backlight class devices will only get registered (by default) when a GPU driver asks for this by calling acpi_video_register_backlight(). This is causing backlight control to be missing on some systems. Patches 1-4 fix this and ideally these should be send to Linus for an upcoming 6.3-rc# release. 2. Now that the dust has settled a bit on the backlight refactor we can do some further cleanups. This is done in patches 5 + 6. Note that patch 5 depends on patch 2. Regards, Hans Hans de Goede (6): ACPI: video: Add auto_detect arg to __acpi_video_get_backlight_type() ACPI: video: Make acpi_backlight=video work independent from GPU driver ACPI: video: Add acpi_backlight=video quirk for Apple iMac14,1 and iMac14,2 ACPI: video: Add acpi_backlight=video quirk for Lenovo ThinkPad W530 ACPI: video: Remove register_backlight_delay module option and code ACPI: video: Remove desktops without backlight DMI quirks drivers/acpi/acpi_video.c | 53 +++-------- drivers/acpi/video_detect.c | 93 +++++++++---------- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 - include/acpi/video.h | 17 +++- 4 files changed, 71 insertions(+), 96 deletions(-)