| Message ID | 20230926-pcc_defines-v1-0-0f925a1658fd@arm.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ACPI: PCC: Define and use the common PCC shared memory regions related macros | expand |
Hi Sudeep, Could you please use these new common macros for kunpeng_hccs? 在 2023/9/26 20:27, Sudeep Holla 写道: > This set of 3 small patches intend to consolidate and replace the existing > locally defined macros within couple of PCC client drivers when accessing > the command and status bitfields. > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > Sudeep Holla (3): > ACPI: PCC: Add PCC shared memory region command and status bitfields > i2c: xgene-slimpro: Migrate to use generic PCC shmem related macros > hwmon: (xgene) Migrate to use generic PCC shmem related macros > > drivers/hwmon/xgene-hwmon.c | 16 +++++----------- > drivers/i2c/busses/i2c-xgene-slimpro.c | 16 ++++------------ > include/acpi/pcc.h | 11 +++++++++++ > 3 files changed, 20 insertions(+), 23 deletions(-) > --- > base-commit: 6465e260f48790807eef06b583b38ca9789b6072 > change-id: 20230926-pcc_defines-24be5e33b6f3 > > Best regards,
On Wed, Sep 27, 2023 at 10:11:21AM +0800, lihuisong (C) wrote: > Hi Sudeep, > > Could you please use these new common macros for kunpeng_hccs? Sure, sorry for missing that. I had these changes in a branch for a while, did check for new additions when I decided to post them.
On Tue, Sep 26, 2023 at 2:33 PM Sudeep Holla <sudeep.holla@arm.com> wrote: > > This set of 3 small patches intend to consolidate and replace the existing > locally defined macros within couple of PCC client drivers when accessing > the command and status bitfields. > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > Sudeep Holla (3): > ACPI: PCC: Add PCC shared memory region command and status bitfields > i2c: xgene-slimpro: Migrate to use generic PCC shmem related macros > hwmon: (xgene) Migrate to use generic PCC shmem related macros > > drivers/hwmon/xgene-hwmon.c | 16 +++++----------- > drivers/i2c/busses/i2c-xgene-slimpro.c | 16 ++++------------ > include/acpi/pcc.h | 11 +++++++++++ > 3 files changed, 20 insertions(+), 23 deletions(-) > --- This is fine with me. How do you want to route it?
On Wed, Sep 27, 2023 at 04:19:21PM +0200, Rafael J. Wysocki wrote: > On Tue, Sep 26, 2023 at 2:33 PM Sudeep Holla <sudeep.holla@arm.com> wrote: > > > > This set of 3 small patches intend to consolidate and replace the existing > > locally defined macros within couple of PCC client drivers when accessing > > the command and status bitfields. > > > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > > --- > > Sudeep Holla (3): > > ACPI: PCC: Add PCC shared memory region command and status bitfields > > i2c: xgene-slimpro: Migrate to use generic PCC shmem related macros > > hwmon: (xgene) Migrate to use generic PCC shmem related macros > > > > drivers/hwmon/xgene-hwmon.c | 16 +++++----------- > > drivers/i2c/busses/i2c-xgene-slimpro.c | 16 ++++------------ > > include/acpi/pcc.h | 11 +++++++++++ > > 3 files changed, 20 insertions(+), 23 deletions(-) > > --- > > This is fine with me. > > How do you want to route it? I have to respin this to include another driver. I also have 2 PCC mailbox driver changes that I wanted to send a pull request to you. I can make this part of that PR or you can take it directly. Both hwmon and i2c maintainers have acked now. -- Regards, Sudeep
On Wed, Sep 27, 2023 at 4:47 PM Sudeep Holla <sudeep.holla@arm.com> wrote: > > On Wed, Sep 27, 2023 at 04:19:21PM +0200, Rafael J. Wysocki wrote: > > On Tue, Sep 26, 2023 at 2:33 PM Sudeep Holla <sudeep.holla@arm.com> wrote: > > > > > > This set of 3 small patches intend to consolidate and replace the existing > > > locally defined macros within couple of PCC client drivers when accessing > > > the command and status bitfields. > > > > > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > > > --- > > > Sudeep Holla (3): > > > ACPI: PCC: Add PCC shared memory region command and status bitfields > > > i2c: xgene-slimpro: Migrate to use generic PCC shmem related macros > > > hwmon: (xgene) Migrate to use generic PCC shmem related macros > > > > > > drivers/hwmon/xgene-hwmon.c | 16 +++++----------- > > > drivers/i2c/busses/i2c-xgene-slimpro.c | 16 ++++------------ > > > include/acpi/pcc.h | 11 +++++++++++ > > > 3 files changed, 20 insertions(+), 23 deletions(-) > > > --- > > > > This is fine with me. > > > > How do you want to route it? > > I have to respin this to include another driver. > > I also have 2 PCC mailbox driver changes that I wanted to send a pull request > to you. I can make this part of that PR or you can take it directly. Both > hwmon and i2c maintainers have acked now. A PR would be convenient. :-)
This set of 3 small patches intend to consolidate and replace the existing locally defined macros within couple of PCC client drivers when accessing the command and status bitfields. Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- Sudeep Holla (3): ACPI: PCC: Add PCC shared memory region command and status bitfields i2c: xgene-slimpro: Migrate to use generic PCC shmem related macros hwmon: (xgene) Migrate to use generic PCC shmem related macros drivers/hwmon/xgene-hwmon.c | 16 +++++----------- drivers/i2c/busses/i2c-xgene-slimpro.c | 16 ++++------------ include/acpi/pcc.h | 11 +++++++++++ 3 files changed, 20 insertions(+), 23 deletions(-) --- base-commit: 6465e260f48790807eef06b583b38ca9789b6072 change-id: 20230926-pcc_defines-24be5e33b6f3 Best regards,