[v5,0/7] ipu6: get rid of all the IS_ENABLED(CONFIG_ACPI)

Message

Ricardo Ribalda Dec. 16, 2024, 9:17 p.m. UTC

We want to be able to compile_test the ipu6 driver in situations with
!ACPI.

In order to do this we had to add some conditional #ifs, which lead to
false positives on the static analysers.

Let's implement some helpers when !ACPI in the acpi headers to make the
code more easier to maintain.

To: Rafael J. Wysocki <[e-mail]>
To: Len Brown <[e-mail]>
To: Robert Moore <[e-mail]>
To: Rafael J. Wysocki <[e-mail]>
Cc: Sakari Ailus <[e-mail]>
Cc: Dan Carpenter <[e-mail]>
Cc: [e-mail]
Cc: [e-mail]
Cc: [e-mail]
Signed-off-by: Ricardo Ribalda <[e-mail]>

Changes in v5:
- Remove Fixes tag
- redefine acpi_get_physical_device_location() to return bool
- Link to v4: https://lore.kernel.org/r/[e-mail]

Changes in v4 (Thanks Sakari & Mauro):
- Squash the two ipu changes and merge everything via ACPI
- Space after ;
- move acpi_device_handle to avoid fwd declaration.
- Link to v3: https://lore.kernel.org/r/[e-mail]

Changes in v3:
- Prefer static inlines to macros (Thanks Rafael).
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
- Add helpers in acpi to avoid conditional compilation
- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Ricardo Ribalda (7):
      ACPI: bus: change the prototype for acpi_get_physical_device_location
      ACPI: bus: implement for_each_acpi_dev_match when !ACPI
      ACPI: bus: implement acpi_get_physical_device_location when !ACPI
      ACPI: header: implement acpi_device_handle when !ACPI
      ACPI: bus: implement for_each_acpi_consumer_dev when !ACPI
      ACPI: bus: implement acpi_device_hid when !ACPI
      media: ipu-bridge: Remove unneeded conditional compilations

 drivers/acpi/mipi-disco-img.c        |  3 +--
 drivers/acpi/scan.c                  |  4 +---
 drivers/acpi/utils.c                 |  7 +++----
 drivers/base/physical_location.c     |  4 +---
 drivers/media/pci/intel/ipu-bridge.c | 29 ++++-------------------------
 drivers/usb/core/usb-acpi.c          |  3 +--
 include/acpi/acpi_bus.h              | 23 ++++++++++++++++++++---
 include/linux/acpi.h                 |  5 +++++
 8 files changed, 36 insertions(+), 42 deletions(-)
---
base-commit: d216d9cb4dd854ef0a2ec1701f403facb298af51
change-id: 20241122-fix-ipu-a2fe28908964

Best regards,

Comments

Rafael J. Wysocki Dec. 19, 2024, 8:01 p.m. UTC | #1

On Mon, Dec 16, 2024 at 10:17 PM Ricardo Ribalda <[e-mail]> wrote:
>
> We want to be able to compile_test the ipu6 driver in situations with
> !ACPI.
>
> In order to do this we had to add some conditional #ifs, which lead to
> false positives on the static analysers.
>
> Let's implement some helpers when !ACPI in the acpi headers to make the
> code more easier to maintain.
>
> To: Rafael J. Wysocki <[e-mail]>
> To: Len Brown <[e-mail]>
> To: Robert Moore <[e-mail]>
> To: Rafael J. Wysocki <[e-mail]>
> Cc: Sakari Ailus <[e-mail]>
> Cc: Dan Carpenter <[e-mail]>
> Cc: [e-mail]
> Cc: [e-mail]
> Cc: [e-mail]
> Signed-off-by: Ricardo Ribalda <[e-mail]>
>
> Changes in v5:
> - Remove Fixes tag
> - redefine acpi_get_physical_device_location() to return bool
> - Link to v4: https://lore.kernel.org/r/[e-mail]
>
> Changes in v4 (Thanks Sakari & Mauro):
> - Squash the two ipu changes and merge everything via ACPI
> - Space after ;
> - move acpi_device_handle to avoid fwd declaration.
> - Link to v3: https://lore.kernel.org/r/[e-mail]
>
> Changes in v3:
> - Prefer static inlines to macros (Thanks Rafael).
> - Link to v2: https://lore.kernel.org/r/[e-mail]
>
> Changes in v2:
> - Add helpers in acpi to avoid conditional compilation
> - Link to v1: https://lore.kernel.org/r/[e-mail]
>
> ---
> Ricardo Ribalda (7):
>       ACPI: bus: change the prototype for acpi_get_physical_device_location
>       ACPI: bus: implement for_each_acpi_dev_match when !ACPI
>       ACPI: bus: implement acpi_get_physical_device_location when !ACPI
>       ACPI: header: implement acpi_device_handle when !ACPI
>       ACPI: bus: implement for_each_acpi_consumer_dev when !ACPI
>       ACPI: bus: implement acpi_device_hid when !ACPI
>       media: ipu-bridge: Remove unneeded conditional compilations
>
>  drivers/acpi/mipi-disco-img.c        |  3 +--
>  drivers/acpi/scan.c                  |  4 +---
>  drivers/acpi/utils.c                 |  7 +++----
>  drivers/base/physical_location.c     |  4 +---
>  drivers/media/pci/intel/ipu-bridge.c | 29 ++++-------------------------
>  drivers/usb/core/usb-acpi.c          |  3 +--
>  include/acpi/acpi_bus.h              | 23 ++++++++++++++++++++---
>  include/linux/acpi.h                 |  5 +++++
>  8 files changed, 36 insertions(+), 42 deletions(-)
> ---

Series applied as 6.14 material, thanks!