| Message ID | 20241224140131.30362-2-kuurtb@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Device managed platform_profile_register() | expand |
Am 24.12.24 um 15:01 schrieb Kurt Borja: > Hi :) > > This is meant to be merged on the pdx86 tree. > > ~ Kurt After thinking about it my second commit regarding the first patch is invalid, so for the whole series: Reviewed-by: Armin Wolf <W_Armin@gmx.de> > v2: > - Replaced convoluted cast with intermediate variable (1/2) > - Restored dropped empty line (1/2) > - Couldn't incorporate Armin's second comment. I probably didn't > understand it (1/2) > v1: > - https://lore.kernel.org/platform-driver-x86/20241221070817.3764-2-kuurtb@gmail.com > > Kurt Borja (2): > ACPI: platform_profile: Add devm_platform_profile_register() > alienware-wmi: Use devm_platform_profile_register() > > drivers/acpi/platform_profile.c | 29 +++++++++++++++++++++++ > drivers/platform/x86/dell/alienware-wmi.c | 10 +------- > include/linux/platform_profile.h | 1 + > 3 files changed, 31 insertions(+), 9 deletions(-) > > > base-commit: 03f8e0e05510dad6377cd5ef029594d30e6c096d
On Tue, 24 Dec 2024, Kurt Borja wrote: > Hi :) > > This is meant to be merged on the pdx86 tree. > > ~ Kurt > > v2: > - Replaced convoluted cast with intermediate variable (1/2) > - Restored dropped empty line (1/2) > - Couldn't incorporate Armin's second comment. I probably didn't > understand it (1/2) > v1: > - https://lore.kernel.org/platform-driver-x86/20241221070817.3764-2-kuurtb@gmail.com > > Kurt Borja (2): > ACPI: platform_profile: Add devm_platform_profile_register() > alienware-wmi: Use devm_platform_profile_register() > > drivers/acpi/platform_profile.c | 29 +++++++++++++++++++++++ > drivers/platform/x86/dell/alienware-wmi.c | 10 +------- > include/linux/platform_profile.h | 1 + > 3 files changed, 31 insertions(+), 9 deletions(-) Thanks. I've now applied these. The first patch is already in the for-next branch and the second is currently in the review-ilpo-next branch (as I wanted to retain ability to easily separate changes into platform_profile.c from the rest, they go to their own branch first).
On Mon, Dec 30, 2024 at 08:31:28PM +0200, Ilpo Järvinen wrote: > On Tue, 24 Dec 2024, Kurt Borja wrote: > > > Hi :) > > > > This is meant to be merged on the pdx86 tree. > > > > ~ Kurt > > > > v2: > > - Replaced convoluted cast with intermediate variable (1/2) > > - Restored dropped empty line (1/2) > > - Couldn't incorporate Armin's second comment. I probably didn't > > understand it (1/2) > > v1: > > - https://lore.kernel.org/platform-driver-x86/20241221070817.3764-2-kuurtb@gmail.com > > > > Kurt Borja (2): > > ACPI: platform_profile: Add devm_platform_profile_register() > > alienware-wmi: Use devm_platform_profile_register() > > > > drivers/acpi/platform_profile.c | 29 +++++++++++++++++++++++ > > drivers/platform/x86/dell/alienware-wmi.c | 10 +------- > > include/linux/platform_profile.h | 1 + > > 3 files changed, 31 insertions(+), 9 deletions(-) > > Thanks. I've now applied these. > > The first patch is already in the for-next branch and the second is > currently in the review-ilpo-next branch (as I wanted to retain ability to > easily separate changes into platform_profile.c from the rest, they go to > their own branch first). Thanks Ilpo! Should I rebase the alienware-wmi rework patch series on top of review-ilpo-next in v3? Currently it's on top of for-next branch. ~ Kurt > > -- > i. >
On Tue, 31 Dec 2024, Kurt Borja wrote: > On Mon, Dec 30, 2024 at 08:31:28PM +0200, Ilpo Järvinen wrote: > > On Tue, 24 Dec 2024, Kurt Borja wrote: > > > > > Hi :) > > > > > > This is meant to be merged on the pdx86 tree. > > > > > > ~ Kurt > > > > > > v2: > > > - Replaced convoluted cast with intermediate variable (1/2) > > > - Restored dropped empty line (1/2) > > > - Couldn't incorporate Armin's second comment. I probably didn't > > > understand it (1/2) > > > v1: > > > - https://lore.kernel.org/platform-driver-x86/20241221070817.3764-2-kuurtb@gmail.com > > > > > > Kurt Borja (2): > > > ACPI: platform_profile: Add devm_platform_profile_register() > > > alienware-wmi: Use devm_platform_profile_register() > > > > > > drivers/acpi/platform_profile.c | 29 +++++++++++++++++++++++ > > > drivers/platform/x86/dell/alienware-wmi.c | 10 +------- > > > include/linux/platform_profile.h | 1 + > > > 3 files changed, 31 insertions(+), 9 deletions(-) > > > > Thanks. I've now applied these. > > > > The first patch is already in the for-next branch and the second is > > currently in the review-ilpo-next branch (as I wanted to retain ability to > > easily separate changes into platform_profile.c from the rest, they go to > > their own branch first). > > Thanks Ilpo! > > Should I rebase the alienware-wmi rework patch series on top of > review-ilpo-next in v3? Currently it's on top of for-next branch. Hi Kurt, You've probably seen it by now but in general, the content in those review-ilpo-* branches is just a staging area to what will become the for-next or fixes branch once LKP has been able to build test the changes. If no issues appear, they'll become content of the for-next or fixes branch as is. In case of problems, I will rebase/edit/drop patches in the review-ilpo-* branches with a relatively low bar so it might not always be fast-forwardable but other than that minor annoyance, I see no issue in basing your work on top of those branches (in particular, if you know there are going to be conflicts). I might rebase also fixes and for-next at times, but I try to avoid having to do that.