mbox series

[0/10] More Rust bindings for device property reads

Message ID 20250326171411.590681-1-remo@buenzli.dev (mailing list archive)
Headers show
Series More Rust bindings for device property reads | expand

Message

Remo Senekowitsch March 26, 2025, 5:13 p.m. UTC 
More Rust bindings for device property reads

This adds more Rust bindings for reading device properties, based on
Rob Herring's work. I'm working on a driver[1] that uses these, but the
driver has more dependencies than this.

Rob Herring and Dirk Behme did several review iterations over on Zulip
already[1], I'm thankful for their great input.

This is my first time posting to the mailing list, please let me know if
I did anything wrong.

Remo

[1] https://rust-for-linux.zulipchat.com/#narrow/channel/288089-General/topic/DS90UB954.20driver.20done.2C.20ready.20to.20upstream.3F/with/507874342

Comments

Andrew Ballance March 26, 2025, 8:54 p.m. UTC | #1 
Hi thanks for sending these in.

On Wed, Mar 26, 2025 at 12:13 PM Remo Senekowitsch Wrote: 
> This is my first time posting to the mailing list, please let me know if
> I did anything wrong.

you probably will have to resubmit in the patch canonical format[1]

I would recomend reading the docs but in summary:
 - all of your patches should have the subsystem in the subject line.
 - patch 6 is missing a commit message
 - commit messages should be written in the imperitive tone
 - a couple of your commit messages give a reason for the changes but
   do not have a summary of the changes
 - for your v2 you should add a diffstat to your cover letter running
   `git format-patch --base=auto --cover-letter` does this automatically
   for you

Andrew


[1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format
Andy Shevchenko March 27, 2025, 8:42 a.m. UTC | #2 
On Wed, Mar 26, 2025 at 03:54:09PM -0500, Andrew Ballance wrote:
> Hi thanks for sending these in.
> 
> On Wed, Mar 26, 2025 at 12:13 PM Remo Senekowitsch Wrote: 
> > This is my first time posting to the mailing list, please let me know if
> > I did anything wrong.
> 
> you probably will have to resubmit in the patch canonical format[1]
> 
> I would recomend reading the docs but in summary:
>  - all of your patches should have the subsystem in the subject line.
>  - patch 6 is missing a commit message
>  - commit messages should be written in the imperitive tone
>  - a couple of your commit messages give a reason for the changes but
>    do not have a summary of the changes

>  - for your v2 you should add a diffstat to your cover letter running
>    `git format-patch --base=auto --cover-letter` does this automatically
>    for you

Also -v<X> gives the proper versioning.

> [1] https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-canonical-patch-format