mbox series

[v1,0/6] ACPI: glue / driver core: Eliminate acpi_platform_notify() and split device_platform_notify()

Message ID 2780027.e9J7NaK4W3@kreacher (mailing list archive)
Headers show
Series ACPI: glue / driver core: Eliminate acpi_platform_notify() and split device_platform_notify() | expand

Message

Rafael J. Wysocki July 12, 2021, 5:19 p.m. UTC
Hi Greg et al,

This series doesn't change functionality (at least not intentionally), but
it get rids of a few unneeded checks, parameter passing etc.

Patches [1-2/6] simplify the ACPI "glue" code.

Patch [3/6] renames a couple of ACPI functions to avoid name collisions going
forward.

Patch [4/6] gets rid of acpi_platform_notify().

Patch [5/6] rearranges the software nodes code along the lines of what happens
to the ACPI "glue" code in patch [4/6].

Patch [6/6] deals with device_platform_notify().

Please review and let me know if there are any concerns regarding this.

Thanks!

Comments

Greg KH July 12, 2021, 6:04 p.m. UTC | #1
On Mon, Jul 12, 2021 at 07:19:57PM +0200, Rafael J. Wysocki wrote:
> Hi Greg et al,
> 
> This series doesn't change functionality (at least not intentionally), but
> it get rids of a few unneeded checks, parameter passing etc.
> 
> Patches [1-2/6] simplify the ACPI "glue" code.
> 
> Patch [3/6] renames a couple of ACPI functions to avoid name collisions going
> forward.
> 
> Patch [4/6] gets rid of acpi_platform_notify().
> 
> Patch [5/6] rearranges the software nodes code along the lines of what happens
> to the ACPI "glue" code in patch [4/6].
> 
> Patch [6/6] deals with device_platform_notify().
> 
> Please review and let me know if there are any concerns regarding this.

Looks good, I only had one small naming comment on patch 5/6.

thanks,

greg k-h
Andy Shevchenko July 12, 2021, 6:39 p.m. UTC | #2
On Mon, Jul 12, 2021 at 07:19:57PM +0200, Rafael J. Wysocki wrote:
> Hi Greg et al,
> 
> This series doesn't change functionality (at least not intentionally), but
> it get rids of a few unneeded checks, parameter passing etc.
> 
> Patches [1-2/6] simplify the ACPI "glue" code.
> 
> Patch [3/6] renames a couple of ACPI functions to avoid name collisions going
> forward.
> 
> Patch [4/6] gets rid of acpi_platform_notify().
> 
> Patch [5/6] rearranges the software nodes code along the lines of what happens
> to the ACPI "glue" code in patch [4/6].
> 
> Patch [6/6] deals with device_platform_notify().
> 
> Please review and let me know if there are any concerns regarding this.

The result looks good to me, but perhaps the ordering can be changed to
minimize addition of the lines that are going to be removed inside the same
series.

In either case, feel free to add
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Rafael J. Wysocki July 14, 2021, 6:17 p.m. UTC | #3
On Mon, Jul 12, 2021 at 8:39 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Mon, Jul 12, 2021 at 07:19:57PM +0200, Rafael J. Wysocki wrote:
> > Hi Greg et al,
> >
> > This series doesn't change functionality (at least not intentionally), but
> > it get rids of a few unneeded checks, parameter passing etc.
> >
> > Patches [1-2/6] simplify the ACPI "glue" code.
> >
> > Patch [3/6] renames a couple of ACPI functions to avoid name collisions going
> > forward.
> >
> > Patch [4/6] gets rid of acpi_platform_notify().
> >
> > Patch [5/6] rearranges the software nodes code along the lines of what happens
> > to the ACPI "glue" code in patch [4/6].
> >
> > Patch [6/6] deals with device_platform_notify().
> >
> > Please review and let me know if there are any concerns regarding this.
>
> The result looks good to me, but perhaps the ordering can be changed to
> minimize addition of the lines that are going to be removed inside the same
> series.
>
> In either case, feel free to add
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks!