From patchwork Mon Oct 25 06:24:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Yu X-Patchwork-Id: 12580775 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC3CBC433F5 for ; Mon, 25 Oct 2021 06:25:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C406E60E09 for ; Mon, 25 Oct 2021 06:25:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230401AbhJYG1w (ORCPT ); Mon, 25 Oct 2021 02:27:52 -0400 Received: from mga06.intel.com ([134.134.136.31]:22495 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230400AbhJYG1w (ORCPT ); Mon, 25 Oct 2021 02:27:52 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10147"; a="290410112" X-IronPort-AV: E=Sophos;i="5.87,179,1631602800"; d="scan'208";a="290410112" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2021 23:25:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,179,1631602800"; d="scan'208";a="485535226" Received: from chenyu-desktop.sh.intel.com ([10.239.158.186]) by orsmga007.jf.intel.com with ESMTP; 24 Oct 2021 23:25:27 -0700 From: Chen Yu To: linux-acpi@vger.kernel.org Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Ard Biesheuvel , Len Brown , Ashok Raj , Andy Shevchenko , Mike Rapoport , Aubrey Li , Chen Yu , linux-kernel@vger.kernel.org Subject: [PATCH v6 0/4] Introduce Platform Firmware Runtime Update and Telemetry drivers Date: Mon, 25 Oct 2021 14:24:49 +0800 Message-Id: X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org The PFRU (Platform Firmware Runtime Update) kernel interface is designed to interact with the platform firmware interface defined in the `Management Mode Firmware Runtime Update ` specification. The primary function of PFRU is to carry out runtime updates of the platform firmware, which doesn't require the system to be restarted. It also allows telemetry data to be retrieved from the platform firmware. ============= - Change from v5 to v6: - Use Link: tag to add the specification download address. (Andy Shevchenko) - Drop comma for each terminator entry in the enum structure. (Andy Shevchenko) - Remove redundant 'else' in get_image_type(). (Andy Shevchenko) - Directly return results from the switch cases in adjust_efi_size() and pfru_ioctl().(Andy Shevchenko) - Keep comment style consistency by removing the period for one line comment. (Andy Shevchenko) - Remove devm_kfree() if .probe() failed. (Andy Shevchenko) - Remove linux/uuid.h and use raw buffers to contain uuid. (Andy Shevchenko) - Include types.h in pfru.h. (Andy Shevchenko) - Use __u8[16] instead of uuid_t. (Andy Shevchenko) - Replace enum in pfru.h with __u32 as enum size is not the same size on all possible architectures. (Andy Shevchenko) - Simplify the userspace tool to use while loop for getopt_long(). (Andy Shevchenko) - Change from v4 to v5: - Remove Documentation/ABI/pfru, and move the content to kernel doc in include/uapi/linux/pfru.h (Greg Kroah-Hartman) - Shrink the range of ioctl numbers declared in Documentation/userspace-api/ioctl/ioctl-number.rst from 16 to 8. (Greg Kroah-Hartman) - Change global variable struct pfru_device *pfru_dev to per PFRU device. (Greg Kroah-Hartman) - Unregister the misc device in acpi_pfru_remove(). (Greg Kroah-Hartman) - Convert the kzalloc() to devm_kzalloc() in the driver so as to avoid freeing the memory. (Greg Kroah-Hartman) - Fix the compile warning by declaring the pfru_log_ioctl() as static. (kernel test robot LKP) - Change to global variable misc_device to per PFRU device. (Greg Kroah-Hartman) - Remove the telemetry output in commit log. (Greg Kroah-Hartman) - Add link for corresponding userspace tool in the commit log. (Greg Kroah-Hartman) - Replace the telemetry .read() with .mmap() so that the userspace could mmap once, and read multiple times. (Greg Kroah-Hartman) - Change from v3 to v4: - Add Documentation/ABI/testing/pfru to document the ABI and remove Documentation/x86/pfru.rst (Rafael J. Wysocki) - Replace all pr_err() with dev_dbg() (Greg Kroah-Hartman, Rafael J. Wysocki) - returns ENOTTY rather than ENOIOCTLCMD if invalid ioctl command is provided. (Greg Kroah-Hartman) - Remove compat ioctl. (Greg Kroah-Hartman) - Rename /dev/pfru/pfru_update to /dev/acpi_pfru (Greg Kroah-Hartman) - Simplify the check for element of the package in query_capability() (Rafael J. Wysocki) - Remove the loop in query_capability(), query_buffer() and query the package elemenet directly. (Rafael J. Wysocki) - Check the number of elements in case the number of package elements is too small. (Rafael J. Wysocki) - Doing the assignment as initialization in get_image_type(). Meanwhile, returns the type or a negative error code in get_image_type(). (Rafael J. Wysocki) - Put the comments inside the function. (Rafael J. Wysocki) - Returns the size or a negative error code in adjust_efi_size() (Rafael J. Wysocki) - Fix the return value from EFAULT to EINVAL if pfru_valid_revid() does not pass. (Rafael J. Wysocki) - Change the write() to be the code injection/update, the read() to be telemetry retrieval and all of the rest to be ioctl()s under one special device file.(Rafael J. Wysocki) - Remove redundant parens. (Rafael J. Wysocki) - Putting empty code lines after an if () statement that is not followed by a block. (Rafael J. Wysocki) - Remove "goto" tags to make the code more readable. (Rafael J. Wysocki) - Change from v2 to v3: - Use valid types for structures that cross the user/kernel boundary in the uapi header. (Greg Kroah-Hartman) - Rename the structure in uapi to start with a prefix pfru so as to avoid confusing in the global namespace. (Greg Kroah-Hartman) - Change from v1 to v2: - Add a spot in index.rst so it becomes part of the docs build (Jonathan Corbet). - Sticking to the 80-column limit(Jonathan Corbet). - Underline lengths should match the title text(Jonathan Corbet). - Use literal blocks for the code samples(Jonathan Corbet). - Add sanity check for duplicated instance of ACPI device. - Update the driver to work with allocated pfru_device objects. (Mike Rapoport) - For each switch case pair, get rid of the magic case numbers and add a default clause with the error handling.(Mike Rapoport) - Move the obj->type checks outside the switch to reduce redundancy. (Mike Rapoport) - Parse the code_inj_id and drv_update_id at driver initialization time to reduce the re-parsing at runtime. (Mike Rapoport) - Explain in detail how the size needs to be adjusted when doing version check. (Mike Rapoport) - Rename parse_update_result() to dump_update_result() (Mike Rapoport) - Remove redundant return.(Mike Rapoport) - Do not expose struct capsulate_buf_info to uapi, since it is not needed in userspace. (Mike Rapoport) - Do not allow non-root user to run this test.(Shuah Khan) - Test runs on platform without pfru_telemetry should skip instead of reporting failure/error.(Shuah Khan) - Reuse uapi/linux/pfru.h instead of copying it into the test directory. (Mike Rapoport) Chen Yu (4): efi: Introduce EFI_FIRMWARE_MANAGEMENT_CAPSULE_HEADER and corresponding structures drivers/acpi: Introduce Platform Firmware Runtime Update device driver drivers/acpi: Introduce Platform Firmware Runtime Update Telemetry tools: Introduce power/acpi/pfru/pfru .../userspace-api/ioctl/ioctl-number.rst | 1 + drivers/acpi/Kconfig | 1 + drivers/acpi/Makefile | 1 + drivers/acpi/pfru/Kconfig | 13 + drivers/acpi/pfru/Makefile | 2 + drivers/acpi/pfru/pfru_update.c | 982 ++++++++++++++++++ include/linux/efi.h | 50 + include/uapi/linux/pfru.h | 280 +++++ tools/power/acpi/pfru/Makefile | 25 + tools/power/acpi/pfru/pfru.8 | 137 +++ tools/power/acpi/pfru/pfru.c | 404 +++++++ 11 files changed, 1896 insertions(+) create mode 100644 drivers/acpi/pfru/Kconfig create mode 100644 drivers/acpi/pfru/Makefile create mode 100644 drivers/acpi/pfru/pfru_update.c create mode 100644 include/uapi/linux/pfru.h create mode 100644 tools/power/acpi/pfru/Makefile create mode 100644 tools/power/acpi/pfru/pfru.8 create mode 100644 tools/power/acpi/pfru/pfru.c