From patchwork Wed Mar 18 01:09:01 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lin Ming X-Patchwork-Id: 12715 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n2I1J23c028703 for ; Wed, 18 Mar 2009 01:19:03 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755969AbZCRBSg (ORCPT ); Tue, 17 Mar 2009 21:18:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756045AbZCRBSf (ORCPT ); Tue, 17 Mar 2009 21:18:35 -0400 Received: from mga11.intel.com ([192.55.52.93]:32489 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755969AbZCRBSe (ORCPT ); Tue, 17 Mar 2009 21:18:34 -0400 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 17 Mar 2009 18:15:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.38,381,1233561600"; d="scan'208";a="673786277" Received: from unknown (HELO [10.239.13.35]) ([10.239.13.35]) by fmsmga001.fm.intel.com with ESMTP; 17 Mar 2009 18:22:19 -0700 Subject: Re: linux-next: acpi tree build failure From: Lin Ming To: Stephen Rothwell Cc: Len Brown , "linux-next@vger.kernel.org" , "Moore, Robert" , "linux-acpi@vger.kernel.org" In-Reply-To: <20090318115713.bafedc37.sfr@canb.auug.org.au> References: <20090318115713.bafedc37.sfr@canb.auug.org.au> Date: Wed, 18 Mar 2009 09:09:01 +0800 Message-Id: <1237338541.29562.5.camel@minggr> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1 (2.24.1-2.fc10) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Wed, 2009-03-18 at 08:57 +0800, Stephen Rothwell wrote: > Hi Len, > > Today's (and several previous day's) linux-next build (i386 allmodconfig) > failed like this: > > arch/x86/kernel/cpu/cpufreq/longhaul.c: In function 'longhaul_setstate': > arch/x86/kernel/cpu/cpufreq/longhaul.c:308: error: implicit declaration of function 'acpi_set_register' Please try below patch, ACPI: cpufreq: use new bit register access function Signed-off-by: Lin Ming --- arch/x86/kernel/cpu/cpufreq/longhaul.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) > > (http://kisskb.ellerman.id.au/kisskb/target/421/) > > Caused by commit e2f34512879026beb26827c14b1d1e67c07f2858 ("ACPICA: > Rename ACPI bit register access functions"). > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/x86/kernel/cpu/cpufreq/longhaul.c b/arch/x86/kernel/cpu/cpufreq/longhaul.c index a4cff5d..4e18d51 100644 --- a/arch/x86/kernel/cpu/cpufreq/longhaul.c +++ b/arch/x86/kernel/cpu/cpufreq/longhaul.c @@ -303,7 +303,7 @@ retry_loop: outb(3, 0x22); } else if ((pr != NULL) && pr->flags.bm_control) { /* Disable bus master arbitration */ - acpi_set_register(ACPI_BITREG_ARB_DISABLE, 1); + acpi_write_bit_register(ACPI_BITREG_ARB_DISABLE, 1); } switch (longhaul_version) { @@ -326,7 +326,7 @@ retry_loop: case TYPE_POWERSAVER: if (longhaul_flags & USE_ACPI_C3) { /* Don't allow wakeup */ - acpi_set_register(ACPI_BITREG_BUS_MASTER_RLD, 0); + acpi_write_bit_register(ACPI_BITREG_BUS_MASTER_RLD, 0); do_powersaver(cx->address, clock_ratio_index, dir); } else { do_powersaver(0, clock_ratio_index, dir); @@ -339,7 +339,7 @@ retry_loop: outb(0, 0x22); } else if ((pr != NULL) && pr->flags.bm_control) { /* Enable bus master arbitration */ - acpi_set_register(ACPI_BITREG_ARB_DISABLE, 0); + acpi_write_bit_register(ACPI_BITREG_ARB_DISABLE, 0); } outb(pic2_mask,0xA1); /* restore mask */ outb(pic1_mask,0x21);