From patchwork Fri Apr 24 05:29:40 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhang Rui X-Patchwork-Id: 19755 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n3O5TUuQ024316 for ; Fri, 24 Apr 2009 05:29:30 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752029AbZDXF33 (ORCPT ); Fri, 24 Apr 2009 01:29:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752073AbZDXF33 (ORCPT ); Fri, 24 Apr 2009 01:29:29 -0400 Received: from mga09.intel.com ([134.134.136.24]:46361 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752029AbZDXF32 (ORCPT ); Fri, 24 Apr 2009 01:29:28 -0400 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 23 Apr 2009 22:19:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.40,239,1239001200"; d="scan'208";a="406413853" Received: from rzhang-dt.sh.intel.com (HELO [10.239.36.94]) ([10.239.36.94]) by orsmga002.jf.intel.com with ESMTP; 23 Apr 2009 22:37:14 -0700 Subject: [PATCH] ACPI video: dmi check for broken _BQC on Acer Aspire 5720 From: Zhang Rui To: Len Brown Cc: linux-acpi , "Zhang, Rui" , maximlevitsky@gmail.com Date: Fri, 24 Apr 2009 13:29:40 +0800 Message-Id: <1240550980.7661.544.camel@rzhang-dt> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 (2.22.1-2.fc9) Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org On Acer Aspire 5720, _BQC always returns a value 9 smaller than the actual brightness level. Add dmi quirk for this laptop. http://bugzilla.kernel.org/show_bug.cgi?id=13121 Tested-by: Maxim Levitsky Signed-off-by: Zhang Rui --- drivers/acpi/video.c | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-2.6/drivers/acpi/video.c =================================================================== --- linux-2.6.orig/drivers/acpi/video.c +++ linux-2.6/drivers/acpi/video.c @@ -87,6 +87,8 @@ static const struct acpi_device_id video }; MODULE_DEVICE_TABLE(acpi, video_device_ids); +static int bqc_offset; + static struct acpi_driver acpi_video_bus = { .name = "video", .class = ACPI_VIDEO_CLASS, @@ -556,7 +558,8 @@ acpi_video_device_lcd_get_level_current( - 3 - (*level); *level = device->brightness->levels[*level + 2]; - } + } else if (bqc_offset) + *level += bqc_offset; device->brightness->curr = *level; return 0; } else { @@ -698,6 +701,29 @@ acpi_video_bus_DOS(struct acpi_video_bus return status; } +static int video_bqc_offset(const struct dmi_system_id *d) +{ + bqc_offset = 9; + return 0; +} + +static struct dmi_system_id video_dmi_table[] __initdata = { + /* + * Acer Aspire 5720 _BQC method is broken, + * it always returns a value smaller than the actual brightness level + * http://bugzilla.kernel.org/show_bug.cgi?id=13121 + */ + { + .callback = video_bqc_offset, + .ident = "Acer Aspire 5720", + .matches = { + DMI_MATCH(DMI_BOARD_VENDOR, "Acer"), + DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5720"), + }, + }, + {} +}; + /* * Simple comparison function used to sort backlight levels. */ @@ -2287,6 +2313,8 @@ EXPORT_SYMBOL(acpi_video_register); static int __init acpi_video_init(void) { + dmi_check_system(video_dmi_table); + if (intel_opregion_present()) return 0;