From patchwork Mon Jun 1 14:14:37 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthew Garrett X-Patchwork-Id: 27200 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n51EGL0l022581 for ; Mon, 1 Jun 2009 14:16:21 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751330AbZFAOQK (ORCPT ); Mon, 1 Jun 2009 10:16:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751248AbZFAOQJ (ORCPT ); Mon, 1 Jun 2009 10:16:09 -0400 Received: from cavan.codon.org.uk ([93.93.128.6]:48149 "EHLO vavatch.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194AbZFAOQH (ORCPT ); Mon, 1 Jun 2009 10:16:07 -0400 Received: from 78-86-230-144.zone2.bethere.co.uk ([78.86.230.144] helo=localhost.localdomain) by vavatch.codon.org.uk with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1MB8J3-0006Y3-Rr; Mon, 01 Jun 2009 15:16:05 +0100 From: Matthew Garrett To: linux-acpi@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Matthew Garrett Subject: [PATCH 3/3] dell-wmi: Don't generate errors on empty messages Date: Mon, 1 Jun 2009 15:14:37 +0100 Message-Id: <1243865677-25425-3-git-send-email-mjg@redhat.com> X-Mailer: git-send-email 1.6.2.2 In-Reply-To: <1243865677-25425-2-git-send-email-mjg@redhat.com> References: <1243865677-25425-1-git-send-email-mjg@redhat.com> <1243865677-25425-2-git-send-email-mjg@redhat.com> X-SA-Do-Not-Run: Yes X-SA-Exim-Connect-IP: 78.86.230.144 X-SA-Exim-Mail-From: mjg@redhat.com X-SA-Exim-Scanned: No (on vavatch.codon.org.uk); SAEximRunCond expanded to false Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org There's no point in generating kernel messages if we didn't receive a parsable keyboard event - only do so if there appeared to be a scancode. Signed-off-by: Matthew Garrett --- drivers/platform/x86/dell-wmi.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c index 9f345dc..0f900cc 100644 --- a/drivers/platform/x86/dell-wmi.c +++ b/drivers/platform/x86/dell-wmi.c @@ -176,9 +176,9 @@ static void dell_wmi_notify(u32 value, void *context) input_sync(dell_wmi_input_dev); input_report_key(dell_wmi_input_dev, key->keycode, 0); input_sync(dell_wmi_input_dev); - } else + } else if (buffer[1] & 0xFFFF) printk(KERN_INFO "dell-wmi: Unknown key %x pressed\n", - buffer[1]); + buffer[1] & 0xFFFF); } }