From patchwork Wed Dec 15 10:18:14 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Gong X-Patchwork-Id: 412961 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id oBFAFHL4015728 for ; Wed, 15 Dec 2010 10:15:19 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752538Ab0LOKPP (ORCPT ); Wed, 15 Dec 2010 05:15:15 -0500 Received: from mga09.intel.com ([134.134.136.24]:57248 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752266Ab0LOKPO (ORCPT ); Wed, 15 Dec 2010 05:15:14 -0500 Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP; 15 Dec 2010 02:15:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.59,347,1288594800"; d="scan'208";a="583908424" Received: from gchen-debian.bj.intel.com ([10.238.153.125]) by orsmga002.jf.intel.com with ESMTP; 15 Dec 2010 02:15:13 -0800 Received: from gchen by gchen-debian.bj.intel.com with local (Exim 4.69) (envelope-from ) id 1PSoR7-0007y5-3X; Wed, 15 Dec 2010 18:18:17 +0800 From: Chen Gong To: linux-acpi@vger.kernel.org Cc: Chen Gong Subject: [PATCH] eliminate the usage of printk_ratelimit Date: Wed, 15 Dec 2010 18:18:14 +0800 Message-Id: <1292408294-30584-2-git-send-email-gong.chen@linux.intel.com> X-Mailer: git-send-email 1.7.3.1.120.g38a18 In-Reply-To: <1292408294-30584-1-git-send-email-gong.chen@linux.intel.com> References: <1292408294-30584-1-git-send-email-gong.chen@linux.intel.com> Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Wed, 15 Dec 2010 10:15:19 +0000 (UTC) diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c index 51905d0..29d38ad 100644 --- a/drivers/acpi/apei/ghes.c +++ b/drivers/acpi/apei/ghes.c @@ -180,13 +180,15 @@ static int ghes_copy_tofrom_phys(void *buffer, u64 paddr, u32 len, static int ghes_read_estatus(struct ghes *ghes, int silent) { struct acpi_hest_generic *g = ghes->generic; + /* Not more than 2 messages every 5 seconds */ + static DEFINE_RATELIMIT_STATE(ratelimit, 5*HZ, 2); u64 buf_paddr; u32 len; int rc; rc = acpi_atomic_read(&buf_paddr, &g->error_status_address); if (rc) { - if (!silent && printk_ratelimit()) + if (!silent && __ratelimit(&ratelimit)) pr_warning(FW_WARN GHES_PFX "Failed to read error status block address for hardware error source: %d.\n", g->header.source_id);