From patchwork Mon May 2 22:16:45 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karthigan Srinivasan X-Patchwork-Id: 748522 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p42MGodU007123 for ; Mon, 2 May 2011 22:16:51 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757435Ab1EBWQt (ORCPT ); Mon, 2 May 2011 18:16:49 -0400 Received: from g4t0016.houston.hp.com ([15.201.24.19]:2354 "EHLO g4t0016.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755221Ab1EBWQt (ORCPT ); Mon, 2 May 2011 18:16:49 -0400 Received: from g4t0009.houston.hp.com (g4t0009.houston.hp.com [16.234.32.26]) by g4t0016.houston.hp.com (Postfix) with ESMTP id A2B1214889; Mon, 2 May 2011 22:16:48 +0000 (UTC) Received: from [16.83.41.28] (ks-ubuntu.americas.hpqcorp.net [16.83.41.28]) by g4t0009.houston.hp.com (Postfix) with ESMTP id 5657DC0D4; Mon, 2 May 2011 22:16:48 +0000 (UTC) Subject: Re: [PATCH] drivers/acpi/utils.c: Fixed coding style issues From: Karthigan Srinivasan To: Len Brown , Nicolas Kaiser Cc: "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" In-Reply-To: <1303402099.11855.9.camel@ks-ubuntu> References: <1303341624.11397.2.camel@ks-ubuntu> <20110421102815.5abf133e@absol.kitzblitz> <1303402099.11855.9.camel@ks-ubuntu> Date: Mon, 02 May 2011 17:16:45 -0500 Message-ID: <1304374605.1619.4.camel@ks-ubuntu> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Mon, 02 May 2011 22:16:51 +0000 (UTC) > On Thu, 2011-04-21 at 11:08 -0500, Karthigan Srinivasan wrote: Len - I submitted this patch on 4/21 and have not received any acknowledgement. I am re-submitting it again. Please review and approve. Best Regards, Karthigan Srinivasan. ==== Fixed brace and comment coding style issues is code. Signed-off-by: Karthigan Srinivasan --- drivers/acpi/utils.c | 15 ++++++--------- 1 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/acpi/utils.c b/drivers/acpi/utils.c index b002a47..76eaac2 100644 --- a/drivers/acpi/utils.c +++ b/drivers/acpi/utils.c @@ -99,9 +99,8 @@ acpi_extract_package(union acpi_object *package, union acpi_object *element = &(package->package.elements[i]); - if (!element) { + if (!element) return AE_BAD_DATA; - } switch (element->type) { @@ -185,9 +184,8 @@ acpi_extract_package(union acpi_object *package, u8 **pointer = NULL; union acpi_object *element = &(package->package.elements[i]); - if (!element) { + if (!element) return AE_BAD_DATA; - } switch (element->type) { @@ -303,9 +301,8 @@ acpi_evaluate_reference(acpi_handle handle, u32 i = 0; - if (!list) { + if (!list) return AE_BAD_PARAMETER; - } /* Evaluate object. */ @@ -337,9 +334,9 @@ acpi_evaluate_reference(acpi_handle handle, goto end; } - if (package->package.count > ACPI_MAX_HANDLES) { + if (package->package.count > ACPI_MAX_HANDLES) return AE_NO_MEMORY; - } + list->count = package->package.count; /* Extract package data. */ @@ -373,7 +370,7 @@ acpi_evaluate_reference(acpi_handle handle, end: if (ACPI_FAILURE(status)) { list->count = 0; - //kfree(list->handles); + /* kfree(list->handles); */ } kfree(buffer.pointer);