From patchwork Fri Jun 3 02:42:34 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shaohua Li X-Patchwork-Id: 845552 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter2.kernel.org (8.14.4/8.14.3) with ESMTP id p532gbNt025168 for ; Fri, 3 Jun 2011 02:42:37 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752607Ab1FCCmg (ORCPT ); Thu, 2 Jun 2011 22:42:36 -0400 Received: from mga11.intel.com ([192.55.52.93]:10764 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752278Ab1FCCmg (ORCPT ); Thu, 2 Jun 2011 22:42:36 -0400 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP; 02 Jun 2011 19:42:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.65,313,1304319600"; d="scan'208";a="11199063" Received: from sli10-conroe.sh.intel.com (HELO [10.239.36.123]) ([10.239.36.123]) by fmsmga002.fm.intel.com with ESMTP; 02 Jun 2011 19:42:35 -0700 Subject: [patch 1/2]intel_idle: fix misuse API - resend From: Shaohua Li To: linux acpi Cc: Len Brown , Andrew Morton Date: Fri, 03 Jun 2011 10:42:34 +0800 Message-ID: <1307068954.15392.52.camel@sli10-conroe> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Fri, 03 Jun 2011 02:42:37 +0000 (UTC) smp_call_function() only lets all other CPUs execute specific function, while we expect all CPUs do in intel_idle. Without the fix, we could have one cpu has auto_demotion enabled or has no boradcast timer setup. Usually we don't see impact because auto demotion just harms power and the intel_idle init is called in CPU 0, where boradcast timer delivers interrupt, but this still could be a problem. Signed-off-by: Shaohua Li --- drivers/idle/intel_idle.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux/drivers/idle/intel_idle.c =================================================================== --- linux.orig/drivers/idle/intel_idle.c 2011-05-27 16:47:06.000000000 +0800 +++ linux/drivers/idle/intel_idle.c 2011-06-03 09:47:30.000000000 +0800 @@ -367,7 +367,7 @@ static int intel_idle_probe(void) if (boot_cpu_has(X86_FEATURE_ARAT)) /* Always Reliable APIC Timer */ lapic_timer_reliable_states = LAPIC_TIMER_ALWAYS_RELIABLE; else { - smp_call_function(__setup_broadcast_timer, (void *)true, 1); + on_each_cpu(__setup_broadcast_timer, (void *)true, 1); register_cpu_notifier(&setup_broadcast_notifier); } @@ -459,7 +459,7 @@ static int intel_idle_cpuidle_devices_in } } if (auto_demotion_disable_flags) - smp_call_function(auto_demotion_disable, NULL, 1); + on_each_cpu(auto_demotion_disable, NULL, 1); return 0; } @@ -499,7 +499,7 @@ static void __exit intel_idle_exit(void) cpuidle_unregister_driver(&intel_idle_driver); if (lapic_timer_reliable_states != LAPIC_TIMER_ALWAYS_RELIABLE) { - smp_call_function(__setup_broadcast_timer, (void *)false, 1); + on_each_cpu(__setup_broadcast_timer, (void *)false, 1); unregister_cpu_notifier(&setup_broadcast_notifier); }