| Message ID | 1348177573-7537-1-git-send-email-mjg@redhat.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
On 09/20/2012 04:46 PM, Matthew Garrett wrote: > Drivers may make calls that require the ACPI IPMI driver to have been > initialised already, so make sure that it appears earlier in the build > order. The IPMI driver uses the ACPI namespace as an option to know the address and characteristics of the device. Does that still work? -corey > > Signed-off-by: Matthew Garrett <mjg@redhat.com> > --- > drivers/acpi/Makefile | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile > index 47199e2..82422fe 100644 > --- a/drivers/acpi/Makefile > +++ b/drivers/acpi/Makefile > @@ -47,6 +47,10 @@ acpi-y += video_detect.o > endif > > # These are (potentially) separate modules > + > +# IPMI may be used by other drivers, so it has to initialise before them > +obj-$(CONFIG_ACPI_IPMI) += acpi_ipmi.o > + > obj-$(CONFIG_ACPI_AC) += ac.o > obj-$(CONFIG_ACPI_BUTTON) += button.o > obj-$(CONFIG_ACPI_FAN) += fan.o > @@ -70,6 +74,5 @@ processor-y += processor_idle.o processor_thermal.o > processor-$(CONFIG_CPU_FREQ) += processor_perflib.o > > obj-$(CONFIG_ACPI_PROCESSOR_AGGREGATOR) += acpi_pad.o > -obj-$(CONFIG_ACPI_IPMI) += acpi_ipmi.o > > obj-$(CONFIG_ACPI_APEI) += apei/ -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Sep 20, 2012 at 08:19:48PM -0500, Corey Minyard wrote: > On 09/20/2012 04:46 PM, Matthew Garrett wrote: > >Drivers may make calls that require the ACPI IPMI driver to have been > >initialised already, so make sure that it appears earlier in the build > >order. > > The IPMI driver uses the ACPI namespace as an option to know the > address and characteristics of the device. Does that still work? Yes, the ACPI interpreter is initialised earlier than the IPMI driver discovery.
On 09/20/2012 08:26 PM, Matthew Garrett wrote: > On Thu, Sep 20, 2012 at 08:19:48PM -0500, Corey Minyard wrote: >> On 09/20/2012 04:46 PM, Matthew Garrett wrote: >>> Drivers may make calls that require the ACPI IPMI driver to have been >>> initialised already, so make sure that it appears earlier in the build >>> order. >> The IPMI driver uses the ACPI namespace as an option to know the >> address and characteristics of the device. Does that still work? > Yes, the ACPI interpreter is initialised earlier than the IPMI driver > discovery. > Cool, I'm good with these, then. Thanks, -corey -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile index 47199e2..82422fe 100644 --- a/drivers/acpi/Makefile +++ b/drivers/acpi/Makefile @@ -47,6 +47,10 @@ acpi-y += video_detect.o endif # These are (potentially) separate modules + +# IPMI may be used by other drivers, so it has to initialise before them +obj-$(CONFIG_ACPI_IPMI) += acpi_ipmi.o + obj-$(CONFIG_ACPI_AC) += ac.o obj-$(CONFIG_ACPI_BUTTON) += button.o obj-$(CONFIG_ACPI_FAN) += fan.o @@ -70,6 +74,5 @@ processor-y += processor_idle.o processor_thermal.o processor-$(CONFIG_CPU_FREQ) += processor_perflib.o obj-$(CONFIG_ACPI_PROCESSOR_AGGREGATOR) += acpi_pad.o -obj-$(CONFIG_ACPI_IPMI) += acpi_ipmi.o obj-$(CONFIG_ACPI_APEI) += apei/
Drivers may make calls that require the ACPI IPMI driver to have been initialised already, so make sure that it appears earlier in the build order. Signed-off-by: Matthew Garrett <mjg@redhat.com> --- drivers/acpi/Makefile | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)