| Message ID | 1350088885-13918-1-git-send-email-e-mail@date.by (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Zhang Rui |
| Headers | show |
On ?, 2012-10-13 at 04:41 +0400, Igor Murzov wrote: > There are systems where video module known to work fine regardless > of broken _DOD and ignoring returned value here doesn't cause > any issues later. This should fix brightness controls on some laptops. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=47861 > > Signed-off-by: Igor Murzov <e-mail@date.by> > Reviewed-by: Sergey V <sftp.mtuci@gmail.com> applied to my next branch. thanks, rui > --- > Previous discussion of the issue: > http://thread.gmane.org/gmane.linux.acpi.devel/56345 > > drivers/acpi/video.c | 11 +++++++---- > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c > index f94d4c8..0230cb6 100644 > --- a/drivers/acpi/video.c > +++ b/drivers/acpi/video.c > @@ -1345,12 +1345,15 @@ static int > acpi_video_bus_get_devices(struct acpi_video_bus *video, > struct acpi_device *device) > { > - int status; > + int status = 0; > struct acpi_device *dev; > > - status = acpi_video_device_enumerate(video); > - if (status) > - return status; > + /* > + * There are systems where video module known to work fine regardless > + * of broken _DOD and ignoring returned value here doesn't cause > + * any issues later. > + */ > + acpi_video_device_enumerate(video); > > list_for_each_entry(dev, &device->children, node) { > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index f94d4c8..0230cb6 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c @@ -1345,12 +1345,15 @@ static int acpi_video_bus_get_devices(struct acpi_video_bus *video, struct acpi_device *device) { - int status; + int status = 0; struct acpi_device *dev; - status = acpi_video_device_enumerate(video); - if (status) - return status; + /* + * There are systems where video module known to work fine regardless + * of broken _DOD and ignoring returned value here doesn't cause + * any issues later. + */ + acpi_video_device_enumerate(video); list_for_each_entry(dev, &device->children, node) {