From patchwork Sat Oct 13 00:41:25 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Igor Murzov X-Patchwork-Id: 1588511 X-Patchwork-Delegate: rui.zhang@intel.com Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork1.kernel.org (Postfix) with ESMTP id 166F93FD9C for ; Sat, 13 Oct 2012 00:49:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752822Ab2JMAti (ORCPT ); Fri, 12 Oct 2012 20:49:38 -0400 Received: from forward4h.mail.yandex.net ([84.201.186.22]:59753 "EHLO forward4h.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752809Ab2JMAth (ORCPT ); Fri, 12 Oct 2012 20:49:37 -0400 X-Greylist: delayed 390 seconds by postgrey-1.27 at vger.kernel.org; Fri, 12 Oct 2012 20:49:37 EDT Received: from smtp1h.mail.yandex.net (smtp1h.mail.yandex.net [84.201.187.144]) by forward4h.mail.yandex.net (Yandex) with ESMTP id 78DA21B21149; Sat, 13 Oct 2012 04:42:54 +0400 (MSK) Received: from smtp1h.mail.yandex.net (localhost [127.0.0.1]) by smtp1h.mail.yandex.net (Yandex) with ESMTP id DE52913402B5; Sat, 13 Oct 2012 04:42:53 +0400 (MSK) Received: from unknown (unknown [46.173.39.73]) by smtp1h.mail.yandex.net (nwsmtp/Yandex) with ESMTP id gcgaSX1A-grgKfDvB; Sat, 13 Oct 2012 04:42:53 +0400 From: Igor Murzov To: linux-acpi@vger.kernel.org Cc: Zhang Rui , Len Brown , Stefan Wilkens , Sergey V , linux-kernel@vger.kernel.org, Igor Murzov Subject: [PATCH] ACPI video: Ignore errors after _DOD evaluation. Date: Sat, 13 Oct 2012 04:41:25 +0400 Message-Id: <1350088885-13918-1-git-send-email-e-mail@date.by> X-Mailer: git-send-email 1.7.12.1 Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org There are systems where video module known to work fine regardless of broken _DOD and ignoring returned value here doesn't cause any issues later. This should fix brightness controls on some laptops. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=47861 Signed-off-by: Igor Murzov Reviewed-by: Sergey V --- Previous discussion of the issue: http://thread.gmane.org/gmane.linux.acpi.devel/56345 drivers/acpi/video.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/acpi/video.c b/drivers/acpi/video.c index f94d4c8..0230cb6 100644 --- a/drivers/acpi/video.c +++ b/drivers/acpi/video.c @@ -1345,12 +1345,15 @@ static int acpi_video_bus_get_devices(struct acpi_video_bus *video, struct acpi_device *device) { - int status; + int status = 0; struct acpi_device *dev; - status = acpi_video_device_enumerate(video); - if (status) - return status; + /* + * There are systems where video module known to work fine regardless + * of broken _DOD and ignoring returned value here doesn't cause + * any issues later. + */ + acpi_video_device_enumerate(video); list_for_each_entry(dev, &device->children, node) {