From patchwork Fri Oct 19 00:33:41 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel J Blueman X-Patchwork-Id: 1614301 Return-Path: X-Original-To: patchwork-linux-acpi@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 34449DFFED for ; Fri, 19 Oct 2012 00:34:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751713Ab2JSAeL (ORCPT ); Thu, 18 Oct 2012 20:34:11 -0400 Received: from mail-da0-f46.google.com ([209.85.210.46]:48831 "EHLO mail-da0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751665Ab2JSAeL (ORCPT ); Thu, 18 Oct 2012 20:34:11 -0400 Received: by mail-da0-f46.google.com with SMTP id n41so3733315dak.19 for ; Thu, 18 Oct 2012 17:34:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=XHRLZLHMdIi2K5riyxoACbIWDg4y3H2TW8PQE3GbEow=; b=oaTLwidO6v/SQKao33zkwhWwKicHQfLSwOHTeV/p2+oF0xeaYe2Ck7OYFWWQ14DeMw fH79UIveCXsL8LYAFw/N9Lj3Ju0jeMyPFjAjBoq7+B11K98kz0qvzRnZAJRfJ0ltbPwJ ZjPQo10Mxe66yhgh+XCwEK4dj77anAZD1I15WiZDll8vaRxoxoGkvpwP7y3NxBuG9st1 MRMcLtxkQPb7gO8X5mdm/1piYoEJRgHeAcJNApKt3uakIFS6cc4l0lT2xA4HF31KsON6 doz15S/R9EsbeYaYmwK8yX6yyHYYosoO5okWX2RFdjvksdzozYdoIhW2ypYBIYWiAziJ /iYA== Received: by 10.66.77.39 with SMTP id p7mr64450349paw.8.1350606850404; Thu, 18 Oct 2012 17:34:10 -0700 (PDT) Received: from meiko.1dn ([115.42.131.38]) by mx.google.com with ESMTPS id gl9sm269214pbc.51.2012.10.18.17.34.07 (version=SSLv3 cipher=OTHER); Thu, 18 Oct 2012 17:34:09 -0700 (PDT) From: Daniel J Blueman To: Len Brown Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel J Blueman Subject: [PATCH] Fix printing when no interrupt is allocated Date: Fri, 19 Oct 2012 08:33:41 +0800 Message-Id: <1350606821-29813-1-git-send-email-daniel@numascale-asia.com> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQl2uKSN2LjFPUThqYRoKbT2SbGqH3qXCB2QonMNuD2U+4zayyb87eZXI2n0yYX6yJPwqmb/ Sender: linux-acpi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Previously a new line is implicitly added in the no GSI case: [ 7.185182] pci 0001:00:12.0: can't derive routing for PCI INT A [ 7.191352] pci 0001:00:12.0: PCI INT A: no GSI [ 7.195956] - using ISA IRQ 10 The code thus prints a blank line where no legacy IRQ is available: [ 1.650124] pci 0000:00:14.0: can't derive routing for PCI INT A [ 1.650126] pci 0000:00:14.0: PCI INT A: no GSI [ 1.650126] [ 1.650180] pci 0000:00:14.0: can't derive routing for PCI INT A Fix this by making the newline explicit and removing the superfluous one. Signed-off-by: Daniel J Blueman --- drivers/acpi/pci_irq.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/acpi/pci_irq.c b/drivers/acpi/pci_irq.c index 0eefa12..2c37996 100644 --- a/drivers/acpi/pci_irq.c +++ b/drivers/acpi/pci_irq.c @@ -459,7 +459,7 @@ int acpi_pci_irq_enable(struct pci_dev *dev) */ if (gsi < 0) { u32 dev_gsi; - dev_warn(&dev->dev, "PCI INT %c: no GSI", pin_name(pin)); + dev_warn(&dev->dev, "PCI INT %c: no GSI\n", pin_name(pin)); /* Interrupt Line values above 0xF are forbidden */ if (dev->irq > 0 && (dev->irq <= 0xF) && (acpi_isa_irq_to_gsi(dev->irq, &dev_gsi) == 0)) { @@ -467,11 +467,9 @@ int acpi_pci_irq_enable(struct pci_dev *dev) acpi_register_gsi(&dev->dev, dev_gsi, ACPI_LEVEL_SENSITIVE, ACPI_ACTIVE_LOW); - return 0; - } else { - printk("\n"); - return 0; } + + return 0; } rc = acpi_register_gsi(&dev->dev, gsi, triggering, polarity);