Message ID | 1354874882-1162-1-git-send-email-mika.westerberg@linux.intel.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers | show |
On Fri, 7 Dec 2012 12:08:02 +0200 Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > All devices behind Haswell LPSS (Low Power Subsystem) should be represented > as platform devices What about the bus heirarchy ? What about making sure they appear in the PCI resource heirarchy so we don't mash them up if we reassign or allocate other resources on the bus ? Alan -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Dec 07, 2012 at 11:01:26AM +0000, Alan Cox wrote: > On Fri, 7 Dec 2012 12:08:02 +0200 > Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > > > All devices behind Haswell LPSS (Low Power Subsystem) should be represented > > as platform devices > > What about the bus heirarchy ? What about making sure they appear in the > PCI resource heirarchy so we don't mash them up if we reassign or > allocate other resources on the bus ? I'm not sure if I understand what you mean here. We put them in hierarchy if the parent ACPI node has also a physical device bound to it (like PCIe root port). -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> I'm not sure if I understand what you mean here. > > We put them in hierarchy if the parent ACPI node has also a physical device > bound to it (like PCIe root port). Ok -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday, December 07, 2012 12:08:02 PM Mika Westerberg wrote: > All devices behind Haswell LPSS (Low Power Subsystem) should be represented > as platform devices so add them to the acpi_platform_device_ids list. > > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> Applied. Thanks, Rafael > --- > drivers/acpi/scan.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c > index 67a7fa6..8ee379e 100644 > --- a/drivers/acpi/scan.c > +++ b/drivers/acpi/scan.c > @@ -37,6 +37,16 @@ static const struct acpi_device_id acpi_platform_device_ids[] = { > > { "PNP0D40" }, > > + /* Haswell LPSS devices */ > + { "INT33C0", 0 }, > + { "INT33C1", 0 }, > + { "INT33C2", 0 }, > + { "INT33C3", 0 }, > + { "INT33C4", 0 }, > + { "INT33C5", 0 }, > + { "INT33C6", 0 }, > + { "INT33C7", 0 }, > + > { } > }; > >
diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c index 67a7fa6..8ee379e 100644 --- a/drivers/acpi/scan.c +++ b/drivers/acpi/scan.c @@ -37,6 +37,16 @@ static const struct acpi_device_id acpi_platform_device_ids[] = { { "PNP0D40" }, + /* Haswell LPSS devices */ + { "INT33C0", 0 }, + { "INT33C1", 0 }, + { "INT33C2", 0 }, + { "INT33C3", 0 }, + { "INT33C4", 0 }, + { "INT33C5", 0 }, + { "INT33C6", 0 }, + { "INT33C7", 0 }, + { } };
All devices behind Haswell LPSS (Low Power Subsystem) should be represented as platform devices so add them to the acpi_platform_device_ids list. Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com> --- drivers/acpi/scan.c | 10 ++++++++++ 1 file changed, 10 insertions(+)